Closer mirroring between main stats and tag stats #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Hi Cess, can you just screenshot this quick for me and then is it ready to
merge? Thank you!!!
…On Thu, Mar 14, 2019 at 12:58 PM plotsbot ***@***.***> wrote:
2 Messages
📖 @cesswairimu <https://github.com/cesswairimu> Thank you for your pull
request! I’m here to help with some tips and recommendations. Please take a
look at the list provided and help us review and accept your contribution!
And *don’t be discouraged if you see errors* – we’re here to help.
📖 Pull Request is marked as Work in Progress
Generated by 🚫 Danger <https://danger.systems/>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5070 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ45s_u8YFqnzSFCLj6rt-uzGOuQSks5vWn-pgaJpZM4b0t_5>
.
|
|
|
6f675e2 to
00b09d9
Compare
e2979b5 to
6c34bb7
Compare
|
|
|
Looks awesome. Ready to merge? Thanks Cess!!!
…On Wed, Mar 20, 2019 at 1:33 PM Cess ***@***.***> wrote:
[image: unstable]
<https://user-images.githubusercontent.com/17081074/54706150-42662200-4b4f-11e9-90ad-1ba20e69f25c.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5070 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1iN4pv0nzCnXEtVU1bzLWKSTS5Iks5vYnDAgaJpZM4b0t_5>
.
|
1617516 to
0b7ec73
Compare
Change tag graphs to use the new ccontribution_graph_making method
0b7ec73 to
a9cc015
Compare
|
@jywarren its ready now, kindly review. |
jywarren
approved these changes
Mar 21, 2019
|
Very well done Cess! 🎉🙌🏽🔥 |
jywarren
pushed a commit
that referenced
this pull request
Mar 29, 2019
* Closer mirroring between main stats and tag stats Change tag graphs to use the new ccontribution_graph_making method * add select range on view * add range to graph making method * test all records are returned in graphs * fix failing test * fix bug in quiz and comment graph_making * refactoring
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
* Closer mirroring between main stats and tag stats Change tag graphs to use the new ccontribution_graph_making method * add select range on view * add range to graph making method * test all records are returned in graphs * fix failing test * fix bug in quiz and comment graph_making * refactoring
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Closer mirroring between main stats and tag stats Change tag graphs to use the new ccontribution_graph_making method * add select range on view * add range to graph making method * test all records are returned in graphs * fix failing test * fix bug in quiz and comment graph_making * refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change tag graphs to use the new ccontribution graph making method
Fixes #4540
rake test@publiclab/reviewersfor help, in a comment below