Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentry #4944

Merged
merged 2 commits into from
Mar 7, 2019
Merged

sentry #4944

merged 2 commits into from
Mar 7, 2019

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Mar 7, 2019

Fixes #4903

@jywarren jywarren mentioned this pull request Mar 7, 2019
Closed
@siaw23-retired
Copy link
Collaborator

Sweet. Good start!

I'm wondering why you're bundling with Bundler 2 though 🤔

jywarren
jywarren commented Mar 7, 2019
View reviewed changes
Gemfile.lock Outdated
@@ -598,4 +599,4 @@ RUBY VERSION
ruby 2.4.4p296

BUNDLED WITH
1.17.3
2.0.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dunno i must've updated recently. is it a problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, You must use Bundler 2 or greater with this lockfile.

Will try again downgrading bundler...

@siaw23-retired
Copy link
Collaborator

Looks good to me. If they approve maybe you could put a link of where we can track the errors? Maybe in the README or wherever you find appropriate?

@plotsbot
Copy link
Collaborator

plotsbot commented Mar 7, 2019

1 Message
📖 @jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren jywarren merged commit 3b03ed6 into publiclab:master Mar 7, 2019
@jywarren
Copy link
Member Author

jywarren commented Mar 7, 2019

Hmm, its coming through (can't invite yet, but will once we're approved) but there's a sprockets error:

https://sentry.io/share/issue/9b54ec2922c0426683b689eea965ce87/ @siaw23 @icarito

@jywarren
Copy link
Member Author

jywarren commented Mar 7, 2019

ok we are approved, inviting ppl now

@siaw23-retired
Copy link
Collaborator

OK please send me and invite too. I'd love to look around. I think this will help us a lot in improving our application! Thanks for doing this Jeff!!

@icarito
Copy link
Member

icarito commented Mar 9, 2019

Friends I'm loving this! I really wanted to have a window into errors as they were happening!

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
@jywarren @icarito
sentry (publiclab#4944)
b610fff 
* sentry

* gemfile.lock
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@jywarren
sentry (publiclab#4944)
b295fb9 
* sentry

* gemfile.lock
@pdurbin pdurbin mentioned this pull request May 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siaw23-retired siaw23-retired siaw23-retired approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jywarren @siaw23-retired @plotsbot @icarito