Add delay (350ms) to typeahead search

[wanzulfikri]

Fixes #4180

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[plotsbot]

	2 Messages
📖	@wanzulfikri Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[wanzulfikri]

@publiclab/reviewers I was able to set up the site locally and tried typing in the search bar.

I'm not a fast typer (40+ WPM) and here's the result of my simple test (query numbers come from the 'Network' tab in my Firefox dev tool):

"How do I eat" -> 1 GET(status: 200) query

"How do I" --short pause-- "eat" -> 2 GET(status: 200) queries

And if I delete the text in the search bar and type "How do I eat" again -> 1 GET(status:304) query

---

Personal opinion: The delay is not too long nor too short.

My test is definitely imperfect. I would love to know if there's a different way to test.

[kevinzluo]

Thank you for your PR @wanzulfikri and welcome to the PublicLab community!
Everything looks great!

The way you tested the delay was the only way I could think of too. If the 350 ms delay feels fine then we should be good to go!

[wanzulfikri]

No problem @kevinzluo; and thank you for the welcome!

I’ll do what I can to contribute :D