Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed error in styles for note erb #4146

Merged
merged 2 commits into from
Dec 7, 2018
Merged

removed error in styles for note erb #4146

merged 2 commits into from
Dec 7, 2018

Conversation

uzorjchibuzor
Copy link
Contributor

Fixes #4113

I have made the changes as described on the issues page.
Kindly merge if certified.

Thanks.

@uzorjchibuzor
Copy link
Contributor Author

@publiclab/reviewers Travis CI test is failing and I have no idea why..

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove test.sqlite-journal, Gemfile and Gemfile.lock.
Changes looks good to me
Great work

@uzorjchibuzor
Copy link
Contributor Author

I removed them and now codeclimate is not passing

@SidharthBansal
Copy link
Member

I mean you need to untrack the changes for these two files. you don't have to delete them

@plotsbot
Copy link
Collaborator

plotsbot commented Dec 7, 2018

1 Message
📖 @uzorjchibuzor Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@uzorjchibuzor
Copy link
Contributor Author

@SidharthBansal Thanks for your help. all tests are passing now.

@SidharthBansal SidharthBansal dismissed their stale review December 7, 2018 07:36

Changes made successfully

@SidharthBansal
Copy link
Member

You missed
image
Please do the necessary changes and ping me

@uzorjchibuzor
Copy link
Contributor Author

Grab

this is the state of the code on the branch that I am trying to merge, I have removed the lines as instructed.

@SidharthBansal
Copy link
Member

Thanks for the screenshot. They were really helpful.
Merging this issue as soon as travis passes.

@SidharthBansal SidharthBansal merged commit c883a16 into publiclab:master Dec 7, 2018
@SidharthBansal
Copy link
Member

@uzorjchibuzor thanks for contributing at Public Labs. You can work on other tasks to help us.

@uzorjchibuzor uzorjchibuzor deleted the recenter_read_more branch December 7, 2018 16:50
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* untracked GEMFILE

* removed redundant style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants