Attempted fix for i18n fallback #3998
Conversation
Generated by 🚫 Danger |
| config.i18n.fallbacks = true | ||
|
|
||
| #config.i18n.fallbacks = true | ||
| config.i18n.fallbacks = {:en => [:en, :de], :de => [:de, :en]} |
There was a problem hiding this comment.
Cool, did this work for you in your local copy?
There was a problem hiding this comment.
I tried setting up the system in production mode on my system and failed terribly. There were multiple failing migrations. I tried skipping them but because of these skipped migrations many later migrations also failed. Could we test it in staging?
|
Hmm, is it possible to seed your db using only "rake db:setup" instead of
running migrations, though?
…On Thu, Nov 22, 2018 at 12:08 PM Shubham Sangamnerkar < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/environments/production.rb
<#3998 (comment)>:
> @@ -73,8 +73,8 @@
# Enable locale fallbacks for I18n (makes lookups for any locale fall back to
# the I18n.default_locale when a translation can not be found)
- config.i18n.fallbacks = true
-
+ #config.i18n.fallbacks = true
+ config.i18n.fallbacks = {:en => [:en, :de], :de => [:de, :en]}
I tried setting up the system in production mode on my system and failed
terribly. There were multiple failing migrations. I tried skipping them but
because of these skipped migrations many later migrations also failed.
Could we test it in staging?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3998 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ21cwjrSiRNSijlz8V5WKL0Ajnu2ks5uxtnrgaJpZM4Yn0Si>
.
|
|
Hm, well it boots locally for me, but I am not actually not able to reproduce the original bug locally now that I try. |
|
Ah, and you should be able to point production at the same database using |
|
I had to copy the development key from config/secrets.yml to the line for production, too... |
19862a5 to
fc766b6
Compare
|
Ah, hmm, so in production i'm seeing:
Plus all through the HTML: <h3><span class="translation_missing" title="translation missing: de.tag.show.notes_tagged, tag: test">Notes Tagged</span></h3>However these translations really are missing. But i'm not seeing the complete 500 error as in #3961... |
|
So one way to test this would be to push this to the unstable branch, then go to https://unstable.publiclab.org/change_locale/de, then go to https://unstable.publiclab.org/questions/tag/parent:multispectral-imaging/author/nedhorning -- I'm pushing to unstable now. it'll take some time (10 minutes?) then this should be test-able. |
|
Hmm, it seems to have failed? https://jenkins.laboratoriopublico.org/job/Plots-Unstable/348/ |
|
Hmm, i think it needs a push from @icarito - i got an error: |
|
Hmm, Travis also reported a failure, oddly: https://travis-ci.org/publiclab/plots2/builds/460598674?utm_medium=notification&utm_source=email |
|
I believe unstable is working again now, and we should be able to test this starting tomorrow if you like! |
|
Yes sure we can test this on unstable! I am not sure of how we deploy on unstable, but think we have a different link along with a password to test things right @jywarren ? Thank you ! |
|
Hi, to test on unstable, we push to the unstable branch, which only some of us have access to. I just did, and will announce in the chatroom that I've done this so we don't conflict with others - there's only one test server to share. Then you can try it out at https://unstable.publiclab.org ! |
|
OK, it's on there until someone else uses unstable! |
|
Hi @gauravano, should we close this? Thanks!! |
|
@gauravano just checking if this could be closed, what do you think? Thanks, all! |
|
Closing this. Feel free to open if we still need it.Thanks all |
|
Hi @jywarren @cesswairimu sorry for missing out on your comments 😞. I went through the issue this PR aim to solve and looks like we had the closure there. So, maybe we can close the issue too - #3961 . We can ask someone from PL team or from the community from Germany for testing it once more if you folks think it's required. Thanks!! |
|
Thanks @gauravano 👍 will ping Liz on the issue |
Fixes #3961
I am not sure that this would work, but we can try this.