-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added is_verified column to users with default value false #3885
Added is_verified column to users with default value false #3885
Conversation
@Radhikadua123 I am deleting the previous PR and as you said I have made this PR for #3849
What I am not getting is how are we using the expiry time? |
Also, I need some help on finding out why did the test fail and what can be done to fix it. Thanking you in advance. |
@shubhscoder The approach which you are following, needs saving token into the db. But it would be better if we don't save token in db at all. To know how to implement that up, you can check out approach 2 on this comment #3522 (comment) Do let me know in case you have any doubts regarding that approach. About the failing test, @jywarren can you please help us out ? I'm not much aware of the environment, but shouldn't the travis CI delete db before running |
Okay so we can use the second approach. It won't require the addition of one more column. We will have to use some gem to get the encryption and decryption done. |
@shubhscoder Encryption/Decryption was added in #3801 |
Deferred to #3907 |
I saw that you removed these changes from #3907 That's a good practice to make atomic changes in the PR. So, I'm reopening this PR. |
@jywarren Since I'm new to rails, I'm inexperienced with db changes. Though the column addition definition seems fine to me. Can you please review this PR ? Also will it cause down time during the time migration will be ran on the db ? Is that a concern for us ? Any idea ? Also may be @icarito knows about it. |
Hi, no, it won't create significant downtime, no worries! So, now you have to update the Thanks!!! |
Fixes #3849
Thanks!