Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEL Integration to inline maps #3213

Merged
merged 1 commit into from
Aug 7, 2018
Merged

LEL Integration to inline maps #3213

merged 1 commit into from
Aug 7, 2018

Conversation

sagarpreet-chadha
Copy link
Contributor

Fixes #3187 !
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@ghost ghost added the in progress label Aug 7, 2018
@sagarpreet-chadha
Copy link
Contributor Author

Screenshot :

screen shot 2018-08-08 at 12 01 31 am

@sagarpreet-chadha
Copy link
Contributor Author

Kindly merge this after PR #3211 .

@plotsbot
Copy link
Collaborator

plotsbot commented Aug 7, 2018

1 Warning
⚠️ This pull request cannot be merged yet due to merge conflicts. Please resolve them – probably by rebasing – and ask for help (in the comments, or in the chatroom if you get into trouble!.
2 Messages
📖 @sagarpreet-chadha Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren
Copy link
Member

jywarren commented Aug 7, 2018

OK, doing this now!

@jywarren jywarren merged commit c779723 into master Aug 7, 2018
@ghost ghost removed the in progress label Aug 7, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
@emilyashley emilyashley deleted the feature_inline_map branch January 15, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaflet Env. Layers on inset maps?
3 participants