Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _header.html.erb #11115 #11174

Closed
wants to merge 1 commit into from
Closed

Conversation

vedant-z
Copy link
Contributor

@vedant-z vedant-z commented Jun 9, 2022

Fixes #11115

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@vedant-z vedant-z requested a review from a team as a code owner June 9, 2022 10:32
@welcome
Copy link

welcome bot commented Jun 9, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Jun 9, 2022

@codeclimate
Copy link

codeclimate bot commented Jun 9, 2022

Code Climate has analyzed commit 5159fe9 and detected 0 issues on this pull request.

View more on Code Climate.

@vedant-z vedant-z changed the title Update _header.html.erb Update _header.html.erb #11115 Jun 9, 2022
@vedant-z
Copy link
Contributor Author

vedant-z commented Jun 9, 2022

@TildaDares please review these 🙂

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6860403983/artifacts/265108807

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vedant-z, the changes in this PR, #11175 and #11176 should be in one PR. Thanks!!

@vedant-z
Copy link
Contributor Author

vedant-z commented Jun 9, 2022

@TildaDares Sorry but how should I merge all the changes in one PR ?

@vedant-z vedant-z closed this Jun 9, 2022
@TildaDares
Copy link
Member

Hi @vedant-z, did you set up this repo in your local env?

@TildaDares
Copy link
Member

Hi @vedant-z, you can either use the command line or GitHub UI to update this PR. This article should help https://ffeathers.wordpress.com/2020/01/12/how-to-update-your-pr-on-github/

Also, you don't need to close all the PRs. You can leave one open and update that one. Feel free to reach out if you need any more help. Thanks!!

@vedant-z
Copy link
Contributor Author

@TildaDares thanks I will give it a try

@vedant-z vedant-z reopened this Jun 10, 2022
@vedant-z vedant-z closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing translations on layouts/_header.html.erb
2 participants