Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change texts for "settings" page #6871

Closed
jywarren opened this issue Nov 27, 2019 · 27 comments · Fixed by #9240
Closed

Change texts for "settings" page #6871

jywarren opened this issue Nov 27, 2019 · 27 comments · Fixed by #9240
Labels
assigned help wanted requires help by anyone willing to contribute HTML

Comments

@jywarren
Copy link
Member

jywarren commented Nov 27, 2019

Problem

We need to make some text adjustments on this page, https://publiclab.org/settings :

image

To work on :

@steviepubliclab has developed some new text for it! Thanks!

Email Notifications

I want to receive an email

- Whenever there are new posts on topics I follow
- In a daily digest
- In a weekly digest

I want to be notified by email for:

- Comments on my posts
- Likes on my posts
- Comments on all posts I’ve commented on

Browser Notifications

I want to receive browser notifications:

- When I’m mentioned
- When someone likes my work

Let's make these text changes on this page: https://github.com/publiclab/plots2/commits/main/app/views/users/settings.html.erb

Originally posted by @jywarren in #6867 (comment)

@jywarren jywarren added fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute HTML labels Nov 27, 2019
@kushaggarwal
Copy link
Contributor

I would like to work on this

@jywarren
Copy link
Member Author

jywarren commented Nov 28, 2019 via email

@pydevsg pydevsg added beginner gci-candidate reserved-for-gci and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute labels Nov 30, 2019
@publiclab publiclab deleted a comment from pydevsg Nov 30, 2019
@SidharthBansal
Copy link
Member

@pydevsg this issue is already taken by @kushaggarwal so we can't keep it in GCI.
First come first serve is followed in OS.
@kushaggarwal in case you want any help to solve this issue please feel free to ping me or any other mentor.
Best of luck @kushaggarwal
Regards
Sidharth

@kushaggarwal
Copy link
Contributor

Okay Thanks @SidharthBansal
Will surely contact in case of any problem

@kushaggarwal
Copy link
Contributor

Hi I was trying to set up the project inorder to work for the problem above but not able to set it up it says the error as shown image
Can you please help
Screenshot 2019-12-02 at 7 37 40 PM

@SidharthBansal
Copy link
Member

Have you updated your bundle and done bundle install?

@kushaggarwal
Copy link
Contributor

Yes I have executed the bundle update command but it throws the below error first and then the one in above image
Screenshot 2019-12-02 at 10 49 02 PM

@chen-robert
Copy link
Contributor

@kushaggarwal

I just tried it and the installation worked for me on Ubuntu 18.04.3 LTS.

It appears you are running Mac OS, which might have some platform-specific problems. I found this StackOverflow article which might work for you.

gem uninstall libv8
gem install therubyracer -v '0.11.3'
gem install libv8 -v '3.11.8.13' -- --with-system-v8

@cesswairimu
Copy link
Collaborator

cesswairimu commented Dec 3, 2019

Hi all, @kushaggarwal, were u able to fix your issue. Thanks @chen-robert @SidharthBansal 👍

@kushaggarwal
Copy link
Contributor

Yes I am on it will update you soon about the same

@kushaggarwal
Copy link
Contributor

Thanks @chen-robert for your help
Will go through the article I hope this will work

@kushaggarwal
Copy link
Contributor

Hi @chen-robert
I went through the stackoverflow article you mentioned in the above message but was not able to resolve the error, the sam error still persists so can you please help
Also can yo u please help what are the previously installed dependencies that should be installed in the system if any as I might be missing any leading to this error
Thanks

@cesswairimu
Copy link
Collaborator

Hey @chen-robert ,
You could try this command gem update --system if that fails try this sudo apt-get install ruby-dev zlib1g-dev liblzma-dev

@kushaggarwal
Copy link
Contributor

Hello guys,
Sorry for the delay was caught up with my university exams
Will soon make a pull request for the above issue
Thank You

@kushaggarwal
Copy link
Contributor

Hello
In above mentioned layout the slider buttons need to be there for each sub option in the heading like I want to be notified by email

@cesswairimu
Copy link
Collaborator

Hi @kushaggarwal, I believe the slider buttons are already in place...we need to change the text. Thanks

@kushaggarwal
Copy link
Contributor

Okay Thank you will do so

@sssash18
Copy link
Contributor

@publiclab/reviewers Can I take up this task if it's still not done?

@kushaggarwal
Copy link
Contributor

Hello
I am working on this one and will soon generate a pull request for the same
Thank you

@sssash18
Copy link
Contributor

Fine @kushaggarwal ,take your time to complete the task.Thanks

@NitinBhasneria
Copy link
Collaborator

@jywarren Can I work on this issue?

@kushaggarwal
Copy link
Contributor

Hello
I have already submitted a pull request regarding the same

@NitinBhasneria
Copy link
Collaborator

@kushaggarwal then you should edit your pr and write the issue number their in fixes.

@kushaggarwal
Copy link
Contributor

Okay will do so
Thank you

@SidharthBansal
Copy link
Member

SidharthBansal commented Feb 21, 2020 via email

@stale stale bot added the stale label Oct 7, 2020
@cesswairimu cesswairimu removed the stale label Oct 7, 2020
@publiclab publiclab deleted a comment from stale bot Oct 7, 2020
@jywarren
Copy link
Member Author

jywarren commented Oct 8, 2020

Hi folks, just noting that there was a very good start to this in #7259 which could be build upon if someone else would like to take this up!

@jywarren jywarren added the help wanted requires help by anyone willing to contribute label Oct 8, 2020
@Manasa2850
Copy link
Member

I would like to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned help wanted requires help by anyone willing to contribute HTML
Projects
None yet
9 participants