Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cursor to pointer on hover over the wiki "changes" link #4979

Closed
5 tasks
grvsachdeva opened this issue Mar 9, 2019 · 10 comments · Fixed by #5026
Closed
5 tasks

Change cursor to pointer on hover over the wiki "changes" link #4979

grvsachdeva opened this issue Mar 9, 2019 · 10 comments · Fixed by #5026
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML

Comments

@grvsachdeva
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update:
    On /dashboard while viewing wiki changes/updates, you might have hovered over the changes link, the below one
    Screenshot from 2019-03-10 01-24-32

Update this line of code https://github.com/publiclab/plots2/blob/master/app/views/dashboard/_wiki.html.erb#L40 such that cursor changes to pointer on hovering over the link

After changing the view, also attach the screenshot of the updated view of the dashboard in the PR.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@grvsachdeva grvsachdeva added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Mar 9, 2019
@grvsachdeva
Copy link
Member Author

This issue is created for @shreyateeza. Thanks!

@corbettbw
Copy link
Contributor

May I give it a try?

@grvsachdeva
Copy link
Member Author

hey @corbettbw, this issue is created for @shreyateeza as they were waiting for the right issue to start with. I can also create a FTO for you, if you want? Thanks!

@corbettbw
Copy link
Contributor

Oh, no worries! And yes, that would be great! Thanks!

@madeofhuman
Copy link
Contributor

I'd love an FTO as well, @gauravano. 😃 Thank you.

@govindjeevan
Copy link

govindjeevan commented Mar 9, 2019

Hello! Can I have a FTO issue too please? @gauravano

@shreyateeza
Copy link
Contributor

@gauravano Thanks! I am working on this.

@grvsachdeva
Copy link
Member Author

hey @corbettbw and @govindjeevan, added your name to #4963 list and will open FTO for you soon. Thanks!

@daddyjab
Copy link

Hi, @guavarano, I'd love to work on a FTO for this project, too!

shreyateeza added a commit to shreyateeza/plots2 that referenced this issue Mar 12, 2019
@grvsachdeva
Copy link
Member Author

Hey @daddyjab, I have added your name to the list - #4963 and will ping you soon with a FTO. Thanks!

@grvsachdeva grvsachdeva added has-pull-request issues which already have a pull request solving it assigned labels Mar 12, 2019
@grvsachdeva grvsachdeva removed assigned has-pull-request issues which already have a pull request solving it labels Apr 15, 2019
grvsachdeva pushed a commit that referenced this issue Apr 15, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
digitaldina pushed a commit to digitaldina/plots2 that referenced this issue May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants