Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale Deustch doesn't work in Footer #3348

Closed
asquare14 opened this issue Sep 19, 2018 · 14 comments
Closed

Locale Deustch doesn't work in Footer #3348

asquare14 opened this issue Sep 19, 2018 · 14 comments

Comments

@asquare14
Copy link
Member

asquare14 commented Sep 19, 2018

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

Scrolled to the footer. Clicked on the Language Dropdown at Extreme Right. Selected Dutch as my preferred locale.

What did you expect to see that you didn't?

I expected the page to be translated to dutch but it was still english. The Dutch locale doesn't work.

Please show us where to look

https://publiclab.org/?_=1537367148

What's your PublicLab.org username?

asquare14

This can help us diagnose the issue:

Browser, version, and operating system

Tested on Chrome in Ubuntu 16.04

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

@welcome
Copy link

welcome bot commented Sep 19, 2018

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄

@grvsachdeva
Copy link
Member

Hi @asquare14, some months back, we decided to remove the German language from our website due to the number of cases of wrong translations. I guess the language button in footer was a leftover. Thanks for reporting the issue and if you want to solve it, you are most welcome. If you need any help, feel free to ask. Thanks!

@asquare14
Copy link
Member Author

@gauravano Thanks but I'd like to leave this for GCI candidates :) Will work on help-wanted or fto.

@grvsachdeva
Copy link
Member

That's great! I guess for making this issue a GCI candidate, the relevant line of code should be added. What do you think?

@asquare14
Copy link
Member Author

asquare14 commented Sep 19, 2018

Sounds great ! I am busy with my midsems + RGSoC till September end, so I can do it after 30 Sept . I also plan to work on a few issues after that. 😄 Is that ok ? Also, if you're free, please feel free to improve this issue 💛

@grvsachdeva
Copy link
Member

grvsachdeva commented Sep 19, 2018

Actually, I am also in-between my sessional exams but don't worry I will improve this issue as soon as I get some time. All the best for your exams and thanks!

@SidharthBansal
Copy link
Member

Hi I reported this error. But due to some reason @jywarren told that we need not to solve this issue.
Can @jywarren you explain the reason once again to @asquare14 ?

Thanks folks

@SidharthBansal SidharthBansal added gci-candidate first-timers-only They need to be well-formatted using the First-timers_Issue_Template. labels Sep 20, 2018
@jywarren
Copy link
Member

jywarren commented Sep 22, 2018 via email

@SidharthBansal SidharthBansal removed the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Sep 25, 2018
@grvsachdeva
Copy link
Member

grvsachdeva commented Sep 27, 2018

Hi @jywarren , great idea to use user-input. Do you think we should remove the Language button from footer until we get a little started on Language feature to avoid confusion? Thanks!

Edit: Also, as the footer is a feature so only you can edit it, here's the feature to edit - https://publiclab.org/features/13824 in case you agree on removing the button 😅 . Thanks again!

@jywarren
Copy link
Member

jywarren commented Sep 27, 2018 via email

@grvsachdeva
Copy link
Member

@jywarren do you mean - we should restore previously removed translation files with lots of FTOs?

@jywarren
Copy link
Member

jywarren commented Sep 27, 2018 via email

@grvsachdeva
Copy link
Member

grvsachdeva commented Sep 27, 2018

Looking awesome! hopefully, it would be done soon, seeing a number of new contributors 😄 .

@jywarren
Copy link
Member

OK so perhaps I will close this one now as we are seeing uptake on #3262 and #3515 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants