-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale Deustch doesn't work in Footer #3348
Comments
Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 |
Hi @asquare14, some months back, we decided to remove the German language from our website due to the number of cases of wrong translations. I guess the language button in footer was a leftover. Thanks for reporting the issue and if you want to solve it, you are most welcome. If you need any help, feel free to ask. Thanks! |
@gauravano Thanks but I'd like to leave this for GCI candidates :) Will work on help-wanted or fto. |
That's great! I guess for making this issue a GCI candidate, the relevant line of code should be added. What do you think? |
Sounds great ! I am busy with my midsems + RGSoC till September end, so I can do it after 30 Sept . I also plan to work on a few issues after that. 😄 Is that ok ? Also, if you're free, please feel free to improve this issue 💛 |
Actually, I am also in-between my sessional exams but don't worry I will improve this issue as soon as I get some time. All the best for your exams and thanks! |
Hi I reported this error. But due to some reason @jywarren told that we need not to solve this issue. Thanks folks |
Ah yes - so, the issue I believe is simply that there are almost no German
(Deutche) translations available. I'd like to explore ways to have
untranslated strings on the site appear with a small globe icon to prompt
people to attempt a translation:
#3262
Also - this will only translate the website static text, not the content of
the site. So perhaps this issue could be converted to one where we try to
clarify the purpose of the locale dropdown so it better sets expectations!
…On Wed, Sep 19, 2018 at 10:26 AM Atibhi Agrawal ***@***.***> wrote:
Please describe the problem (or idea)
What happened just before the problem occurred? Or what problem could this
idea solve?
Scrolled to the footer. Clicked on the Language Dropdown at Extreme Right.
Selected Dutch as my preferred locale.
What did you expect to see that you didn't?
I expected the page to be translated to dutch but it was still english.
The Dutch locale doesn't work.
Please show us where to look
https://publiclab.org/?_=1537367148
What's your PublicLab.org username?
asquare14
This can help us diagnose the issue:
Browser, version, and operating system
Tested on Chrome in Ubuntu 16.04
Many bugs are related to these -- please help us track it down and
reproduce what you're seeing!
------------------------------
Thank you!
Your help makes Public Lab better! We *deeply* appreciate your helping
refine and improve this site.
To learn how to write really great issues, which increases the chances
they'll be resolved, see:
https://publiclab.org/wiki/developers#Contributing+for+non-coders
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3348>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJx06cquWXZSeXF98RSoFxi8mMHJAks5uclPcgaJpZM4WwSJ4>
.
|
Hi @jywarren , great idea to use user-input. Do you think we should remove the Language button from footer until we get a little started on Language feature to avoid confusion? Thanks! Edit: Also, as the footer is a feature so only you can edit it, here's the feature to edit - https://publiclab.org/features/13824 in case you agree on removing the button 😅 . Thanks again! |
Sure, maybe we could just hide it for now?
There is a translation issue which we could begin to work on. One part
thatd make for lots of good starter issues is to start consolidating the
translation files into just one file... We could make one task per
translation!
On Sep 27, 2018 9:23 AM, "Gaurav Sachdeva" <notifications@github.com> wrote:
Hi @jywarren <https://github.com/jywarren> , great idea to use user-input.
Do you think we should remove the Language button from footer until we get
a little started on Language feature to avoid confusion? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3348 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7G5qiBbDmzH34ekdOQV155CGMqfks5ufNFrgaJpZM4WwSJ4>
.
|
@jywarren do you mean - we should restore previously removed translation files with lots of FTOs? |
Actually i think we could try some of the steps here:
#3262
for one, we should move each language into one big file. but it'll take a
while, but we can do it as individual tasks, what do you think?
…On Thu, Sep 27, 2018 at 9:44 AM Gaurav Sachdeva ***@***.***> wrote:
@jywarren <https://github.com/jywarren> do you mean - we should restore
previously removed translation files with lots of FTOs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3348 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJw3dezRajfZEwVa4tIh9IZ4LnNkBks5ufNYCgaJpZM4WwSJ4>
.
|
Looking awesome! hopefully, it would be done soon, seeing a number of new contributors 😄 . |
Please describe the problem (or idea)
Scrolled to the footer. Clicked on the Language Dropdown at Extreme Right. Selected Dutch as my preferred locale.
I expected the page to be translated to dutch but it was still english. The Dutch locale doesn't work.
Please show us where to look
https://publiclab.org/?_=1537367148
What's your PublicLab.org username?
asquare14
Browser, version, and operating system
Tested on Chrome in Ubuntu 16.04
We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
The text was updated successfully, but these errors were encountered: