Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Strings to Translation Function Call in _sidebar.html.erb #10104

Closed
5 tasks
Tlazypanda opened this issue Aug 26, 2021 · 16 comments · Fixed by #10335
Closed
5 tasks

Add Strings to Translation Function Call in _sidebar.html.erb #10104

Tlazypanda opened this issue Aug 26, 2021 · 16 comments · Fixed by #10335
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. hacktoberfest

Comments

@Tlazypanda
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _sidebar.html.erb and _en.yml in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

_sidebar.html.erb

- 41        <small class="form-grey">Search topics</small>
+ 41       <small class="form-grey"><%= translation('dashboard_v2.sidebar.search_topics') %></small> 

_en.yml

+ 387    search_topics: "Search topics"
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@Tlazypanda Tlazypanda added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Aug 26, 2021
@prathamesh-borse
Copy link

@Tlazypanda Could You Please Assign This issue to me.

@Tlazypanda
Copy link
Collaborator Author

@prathamesh-borse go ahead :)

@DalilaBA
Copy link
Contributor

@prathamesh-borse did you pulled a request ?

@prathamesh-borse
Copy link

prathamesh-borse commented Aug 27, 2021 via email

@Vishal01-git
Copy link
Contributor

Hey @prathamesh-borse , did you pulled a request?

@noi5e
Copy link
Contributor

noi5e commented Sep 7, 2021

@prathamesh-borse Do you need any help with this? Please let me know! 😄 This issue is for first-timers, so we want to help you make a contribution here.

@Vishal01-git
Copy link
Contributor

Hey @prathamesh-borse Please update us , Do you need any help? You are working on this issue or not?

@prathamesh-borse
Copy link

@noi5e @Vishal01-git I am Working on this issue.

@noi5e
Copy link
Contributor

noi5e commented Sep 13, 2021

Great @prathamesh-borse! Let us know if you need any help opening the pull request!

@noi5e
Copy link
Contributor

noi5e commented Sep 27, 2021

It's been two weeks since any activity on this issue, so I'm reassigning it to another person.

@noi5e
Copy link
Contributor

noi5e commented Sep 27, 2021

Issue reserved for the next 24 hours for @Nandini-108

@Nandini-108
Copy link

Yes, I'd like to do it
Thanks

@Onyinye91-ctrl
Copy link
Contributor

@Tlazypanda If this is still open, can you assign it to me?

@Onyinye91-ctrl
Copy link
Contributor

Is this still opened @Tlazypanda

@TildaDares
Copy link
Member

It's been more than a week so I'm reassigning this

@TildaDares
Copy link
Member

Reserved for @kolberg-dev

jywarren pushed a commit that referenced this issue Nov 16, 2021
…10335)

* Add Strings to Translation Function Call in _sidebar.html.erb #10104

* Update en.yml
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
…ab#10104 (publiclab#10335)

* Add Strings to Translation Function Call in _sidebar.html.erb publiclab#10104

* Update en.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants