Tweaks to maps per region #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit d63002db and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
d63002d to
42b39ec
Compare
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 72.43% 72.51% +0.08%
==========================================
Files 35 35
Lines 1335 1339 +4
==========================================
+ Hits 967 971 +4
Misses 368 368
|
|
Cleared the CodeClimate issue! Is this ready for merge? Thanks! |
jywarren
approved these changes
Jul 26, 2019
|
Yeah it is. Thanks @jywarren |
|
🎉 |
chen-robert
pushed a commit
to chen-robert/mapknitter
that referenced
this pull request
Dec 5, 2019
* cache regional maps * add tag filter on maps * test tag filter in regional maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #834
rake test@publiclab/mapknitter-reviewersfor help, in a comment below