Map and gallery template added to tags page

[divyabaid16]

Fixes #807 (<=== Add issue number here)

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/mapknitter-reviewers for help, in a comment below

Thanks!

[codeclimate]

Code Climate has analyzed commit e8f6995 and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #821 into main will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
+ Coverage   72.43%   72.59%   +0.16%     
==========================================
  Files          35       35              
  Lines        1335     1343       +8     
==========================================
+ Hits          967      975       +8     
  Misses        368      368

Impacted Files	Coverage Δ
app/models/map.rb	93.19% <100%> (+0.09%)	⬆️
app/controllers/tags_controller.rb	89.65% <100%> (+1.65%)	⬆️
app/controllers/maps_controller.rb	91.89% <100%> (+0.14%)	⬆️

[divyabaid16]

@publiclab/mapknitter-reviewers

[jywarren]

Oh wow, this is awesome! I was thinking ideally we might show only maps that are tagged -- @sagarpreet-chadha, would it be possible to pass a new RSS URL into the layer, so it'd otherwise be identical but would display https://mapknitter.org/feeds/tag/featured or https://mapknitter.org/feeds/tag/barataria instead of the default?

…

On Tue, Jul 9, 2019 at 6:34 AM Divya Baid ***@***.***> wrote: @publiclab/mapknitter-reviewers <https://github.com/orgs/publiclab/teams/mapknitter-reviewers> — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#821?email_source=notifications&email_token=AAAF6JZNOP2IJTHDNMQO62LP6RSUZA5CNFSM4H7D7BV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZP3MQA#issuecomment-509589056>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J776UAQIYWLK7W7ZE3P6RSUZANCNFSM4H7D7BVQ> .

[divyabaid16]

I'm not getting this. @ananyaarun would you like to give some input on this?
Here, we have to show only the maps that are tagged or has some tag associated with it.
Thanks!

[ananyaarun]

Hey @divyabaid16
What is the exact issue you are facing ?

[divyabaid16]

@ananyaarun have a look at #821 (comment) comment.

The page that displays this is
https://mapknitter.org/tags/featured

Actually I'm not so aware about the layers.

[ananyaarun]

Hi @divyabaid16
I am completely new to mapknitter I had a few questions , So in the https://mapknitter.org/tags/featured page I see on top the mapknitter layer is displayed (this is the LEL mapknitter layer)
But the maps ie the ones with featured tags displayed below have nothing to do with LEL layers do they ?

[divyabaid16]

@jywarren just to clear, were you asking me to sum up the coordinates of all the maps in LEL, find their average and then zoom in to that point in the top map?
And show that point in LEL mapknitter layer?

[jywarren]

Ah actually all the maps that are tagged with the given tag. But that'll be all maps if we adapt the Json endpoint to allow a tag parameter! For the short term fix, you can just use leaflet's getBounds feature to pass all coords in and it'll calculate a bounds to include them all. How does that sound? Thanks!!

…

On Fri, Jul 12, 2019, 4:17 AM Divya Baid ***@***.***> wrote: @jywarren <https://github.com/jywarren> just to clear, were you asking me to sum up the coordinates of all the maps in LEL, find their average and then zoom in to that point in the top map? And show that point in LEL mapknitter layer? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#821?email_source=notifications&email_token=AAAF6J34GYFXSP3TBBADLLDP7A4W7A5CNFSM4H7D7BV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZZCB2Y#issuecomment-510796011>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J5RWVCUVDNJQWWNXETP7A4W7ANCNFSM4H7D7BVQ> .

[jywarren]

Hi all! How is this coming along -- can I help out? Thanks!!!

[divyabaid16]

Ya, I'm trying. Sorry, It took me a bit longer.

[jywarren]

no problem, and if you get stuck, ping me! Thanks, Divya!!!

…

On Thu, Jul 25, 2019 at 9:50 AM Divya Baid ***@***.***> wrote: Ya, I'm trying. Sorry, It took me a bit longer. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#821?email_source=notifications&email_token=AAAF6J2WFY65DBI3TWIQQTLQBGVO5A5CNFSM4H7D7BV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ZQ4LQ#issuecomment-515051054>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4D2WJMRJHR7TZG273QBGVO5ANCNFSM4H7D7BVQ> .

[divyabaid16]

I have made the changes @cesswairimu.
Thanks!

[jywarren]

Nice!!!

[jywarren]

This looks great. merging - and shall we think of how to show people how to use this feature? Like, should this page have a section that says use the tag _____ to add a map to this collection or on a map view page, an area for inputting tags that explains this too? We could move the tags section from the map show page to the view only map page that @cesswairimu built in #777 ? What do you think?

[jywarren]

Oops, closed by mistake!!! I'll merge in any case, since it already passed. Thanks!