Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Mappers Mobile Responsive fix #802

Merged
merged 2 commits into from
Jul 5, 2019

Conversation

divyabaid16
Copy link
Contributor

Fixes #800 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Before:

Peek 2019-07-05 00-23

After:
Peek 2019-07-05 00-19

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • [] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

Thanks!

@codeclimate
Copy link

codeclimate bot commented Jul 4, 2019

Code Climate has analyzed commit cf8a5c1 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 4, 2019

Codecov Report

Merging #802 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #802   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files          35       35           
  Lines        1335     1335           
=======================================
  Hits          967      967           
  Misses        368      368

@jywarren
Copy link
Member

jywarren commented Jul 5, 2019

This is awesome! I think CodeCov is asking that any new PRs have at least the same coverage as the rest of the project. Which in this case maybe doesn't make sense. But we can add a functional or integration test perhaps to improve coverage of this page?

@jywarren jywarren mentioned this pull request Jul 5, 2019
5 tasks
@jywarren jywarren merged commit 8fbc3a8 into publiclab:main Jul 5, 2019
@divyabaid16 divyabaid16 deleted the small-front-ui branch July 6, 2019 16:25
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
* Featured Mappers Mobile Responsive fix

* assert_template 'front_ui/gallery'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small bug in front page UI Mobile Responsive
2 participants