New front page design #743
Conversation
|
Code Climate has analyzed commit f1f43e35 and detected 0 issues on this pull request. View more on Code Climate. |
|
Cool - can you share a screenshot? Thanks @cesswairimu ! |
|
Sure @jywarren |
|
Wow this is looking good! Can we get it to prompt you for your location in
JavaScript geocoding API (this can be in a follow-up) and to re-center the
map if you accept?
https://developer.mozilla.org/en-US/docs/Web/API/Geolocation_API
…On Mon, Jun 24, 2019 at 5:50 PM Cess ***@***.***> wrote:
Sure @jywarren <https://github.com/jywarren>
[image: screencapture-localhost-3000-front-page-2019-06-24-22_50_14]
<https://user-images.githubusercontent.com/17081074/60054413-212f4780-96e3-11e9-8c9e-882becc5aedd.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#743?email_source=notifications&email_token=AAAF6J2BB56ZOB7I46Q2OMLP4E6RFA5CNFSM4H3CFVUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYOKV4Q#issuecomment-505195250>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JYYRCQSQLGI5NQVQMLP4E6RFANCNFSM4H3CFVUA>
.
|
|
Otherwise is this good to merge? Thank you! |
f1f43e3 to
f2fd9d6
Compare
app/helpers/front_ui_helper.rb
Outdated
| @@ -0,0 +1,6 @@ | |||
| module FrontUiHelper | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at module body beginning.
f2fd9d6 to
3ad1678
Compare
|
Locally its working pushing to unstable to confirm this works there as well. |
|
Hey @jywarren , the 'prompt position' fix for prod is taking taking longer. we can merge this for now, I will open another PR for making the location prompt appear in production along with the 'nearby places below the map implementation'. Thanks |
|
Also could it be that we turn off/block pop up notifications in unstable? Thanks |
|
Just came across this https://developers.google.com/web/updates/2016/04/geolocation-on-secure-contexts-only It blocks Geolocation for website using the Geolocation API from pages served over HTTP (non-secure). And unstable uses |
|
Ah! That must be it! You can likely test it locally... or if it fails
perhaps we just ensure it fails gracefully?
…On Tue, Jun 25, 2019 at 5:54 PM Cess ***@***.***> wrote:
Actually came across this
https://developers.google.com/web/updates/2016/04/geolocation-on-secure-contexts-only
It blocks Geolocation for website affects any page currently using the
Geolocation API from pages served over HTTP (non-secure). And unstable uses
http so maybe that might be why 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#743?email_source=notifications&email_token=AAAF6J2ONFVOHLEQNYDELBDP4KHXJA5CNFSM4H3CFVUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYRWS4Y#issuecomment-505637235>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J6CE2VTHB6BPL45KGTP4KHXJANCNFSM4H3CFVUA>
.
|
|
Yeah I did, see gif above ☝️ |
|
Oh awesome! Ready for merge then? Great work! |
|
What do you think about adding an iframe with balloon mapping questions from publiclab.org/balloon-mapping? |
|
You can generate it by pressing the "code" button in lower right of any inline grid: |
|
We could feature a couple grids at the very bottom? |
|
Maybe questions and activities for balloon mapping? |
|
Sounds good 👍 , on it. Thanks |
|
Wow! I have never used iframes before these are super dope. Thanks @jywarren. How does this 👇 look or is it better to have them as separate instead of side by side?
|
531a87b to
57194d2
Compare
|
Hey, these look great!!! Can you look at the failing test, and we can merge this? I might do a round of small CSS tweaks for spacing and such once it's merged. Thanks a lot, Cess! |
|
Actually, where does the link to "more people and maps" go? Should we have some kind of listing page that's a bit like the current front page that it leads to? |
|
Thanks Jeff, that links to this page |
|
Removed some space below the iframes
|
|
OK I'm merging this! Let's brainstorm any next steps. I'd like to maybe make some listing of "all maps" as we have on the old front page, maybe on that 2nd page? Paginated, so you can browse back on old maps? I'll do some styling tweaks to this. How does it render on mobile, do we need to worry about that? Thanks @cesswairimu !!! |
|
Thanks @jywarren .My bad forgot to check mobile view..checking that and will fix if anything that breaks. Will work on the "all maps" page..Any suggestions on what we should call that page? |
|
We could call it the gallery?
…On Thu, Jun 27, 2019, 12:23 PM Cess ***@***.***> wrote:
Thanks @jywarren <https://github.com/jywarren> .My bad forgot to check
mobile view..checking that and will fix if anything that breaks. Will work
on the "all maps" page..Any suggestions on what we should call that page?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#743?email_source=notifications&email_token=AAAF6J24W7TDHLWJ7KOAJKDP4TSOVA5CNFSM4H3CFVUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXUZBI#issuecomment-506416261>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7TMRRPCAJ6MGUBVTDP4TSOVANCNFSM4H3CFVUA>
.
|
|
Nice!!! |
* New Front end page css fixes * images styling * adds mapping kits icons * change prof icon to first image map * Fix mysql2 select list group clause error * remove sections not used * separate css classes * Add iframes for balloon mappings * remove space below iframes
Fixes #327
Adding a little checklist from the issue
rake test@publiclab/mapknitter-reviewersfor help, in a comment below