Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment tweaks including Makefile and start script #418

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

icarito
Copy link
Member

@icarito icarito commented Mar 20, 2019

Some ideas taken from #363 - deployed now on http://mapknitter.laboratoriopublico.org/ !

This has been tested in unstable please merge!

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code has been rebased on top of latest master (check if another pull request was added recently, and please rebase)
  • pull request is descriptively named and, if possible, multiple commits squashed if they're smaller changes

Thanks!

@icarito icarito mentioned this pull request Mar 20, 2019
3 tasks
@jywarren
Copy link
Member

Ah, this is ready to merge?

@jywarren jywarren merged commit f4650a7 into main Mar 20, 2019
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
* Start script plus Makefile

* Add COMPOSE_HTTP_TIMEOUT

* Omit checking subdomains. This should be done at nginx level.

* Add precompile step to Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants