Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup auto-comment on dependabot PRs #1738

Merged
merged 3 commits into from
May 29, 2022
Merged

Setup auto-comment on dependabot PRs #1738

merged 3 commits into from
May 29, 2022

Conversation

PeculiarE
Copy link
Contributor

@PeculiarE PeculiarE commented May 28, 2022

Follow up to #1734

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented May 28, 2022

@codeclimate
Copy link

codeclimate bot commented May 28, 2022

Code Climate has analyzed commit 79cecf7 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #1738 (8341faa) into main (bb4dbb3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   63.47%   63.47%           
=======================================
  Files          39       39           
  Lines        1180     1180           
=======================================
  Hits          749      749           
  Misses        431      431           

@PeculiarE PeculiarE mentioned this pull request May 28, 2022
5 tasks
@PeculiarE
Copy link
Contributor Author

Hi @jywarren....I believe this should work for our purpose. Fingers crossed that it actually does 🤞

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK let's try!!

@jywarren jywarren merged commit b66b754 into publiclab:main May 29, 2022
@jywarren
Copy link
Member

OK, maybe there was still an error? I see #1740 which was created just after we merged this!

@jywarren
Copy link
Member

Error: TypeError: Cannot read property 'number' of undefined
Error: Cannot read property 'number' of undefined

Same error with "number" as i documented... i hope the action author writes back!!

@PeculiarE
Copy link
Contributor Author

PeculiarE commented May 29, 2022

it is working actually, see this PR #1741 opened roughly 10mins after the merge. The comment is made as desired.

I dunno if you saw my comment over at #1734, but I did mention that I decided to no longer use that author's bot. I went ahead to create our own specialized workflow to make the comment using the Github API and Github Actions. Full details here.

@PeculiarE
Copy link
Contributor Author

PeculiarE commented May 29, 2022

I believe the merge had not yet fully completed before #1740 was opened. Because I'm looking at the workflow/checks in its thread now and it's running the old workflow that uses that author's bot (Label Actions / Process Label Action) and that's why it threw the 'number' error.

The next PR opened at #1741 contains the new workflow I created: 'Dependabot PR Auto-Comment task' and this workflow does the job 😄

@jywarren
Copy link
Member

Oh fantastic!!! You must be right. Yes possibly the rebase was only up to a certain commit or something?

Great work, thanks @PeculiarE !!!

PeculiarE added a commit to PeculiarE/mapknitter that referenced this pull request Jul 6, 2022
* chore: delete label-actions.yml

* chore: delete process-label-actions.yml

* chore: create new workflow for auto-comment on dependabot PR thread
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants