-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move the styling on the front_ui/index to stylesheets/front_ui.scss #1223
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1223 +/- ##
=======================================
Coverage 72.92% 72.92%
=======================================
Files 40 40
Lines 1400 1400
=======================================
Hits 1021 1021
Misses 379 379 |
Looks great @katungi, could you please add a screenshot to make sure we did not break anything. Thanks for opening this |
Where do i send the screenshots?
…On Wed, Jan 29, 2020 at 7:12 PM Cess ***@***.***> wrote:
Looks great @katungi <https://github.com/katungi>, could you please add a
screenshot to make sure we did not break anything. Thanks for opening this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1223?email_source=notifications&email_token=AGJZ32ZGWJQO3BJLRQWFI2LRAGTIVA5CNFSM4KMG55S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHY3FQ#issuecomment-579833238>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZ3267KKGPI4FGHFSMZI3RAGTIVANCNFSM4KMG55SQ>
.
|
@cesswairimu there you go. Screenshots added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for working on this 🚀
@@ -1,4 +1,4 @@ | |||
class AddDisplayWelcomeToMaps < ActiveRecord::Migration[5.2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @katungi, I see you modified these three files, could you please remove them since they are not part of the issue?
After this we should be ready to merge. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do remove them @cesswairimu ?
do i gitignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, on your branch do
git log
pick the second last SHA and do
git reset SHA
if you now do git status
you will see the your files unstaged
git add filename
to add the files you only want
then git commit
then git push -f origin branchname
,
Makes sense? Let me know if u get stuck
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fantastic 🚀 Thanks for working on this and welcome to PublicLab 🎈 |
my twitter handle is @warrior_rapid
…On Sun, Feb 2, 2020, 3:27 PM Cess ***@***.***> wrote:
Fantastic 🚀 Thanks for working on this and welcome to PublicLab 🎈
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1223?email_source=notifications&email_token=AGJZ325AWLQQUNLGABDF6ULRA232RA5CNFSM4KMG55S2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRVTAQ#issuecomment-581130626>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZ325UTSNCXABA52JYVUDRA232RANCNFSM4KMG55SQ>
.
|
Fixes #1221 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!