-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added margin between buttons #1195
Conversation
Thanks for opening this pull request! |
Code Climate has analyzed commit 1fe6d7c and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also post a screenshot of your change?
It's a common practice when you send a UI change that it includes a screenshot showcasing the change. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@cesswairimu we can merge this 🎉 |
can you suggest me more issues which i can try?? |
Hi @keshavsethi. I am glad that you are interested in contributing to PublicLab. |
Codecov Report
@@ Coverage Diff @@
## main #1195 +/- ##
==========================================
+ Coverage 72.92% 73.28% +0.35%
==========================================
Files 40 40
Lines 1400 1400
==========================================
+ Hits 1021 1026 +5
+ Misses 379 374 -5
|
Thanks you both 💯 @keshavsethi welocme to mapknitter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🎉 🎉
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
I have done few FTOs in plots2 as well so I think i can try some challenging issues:) |
Fixes #1194
This is pull request for First timers issue 1194 where margin between buttons is added.
Thanks!