Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added margin between buttons #1195

Merged
merged 1 commit into from
Jan 12, 2020
Merged

added margin between buttons #1195

merged 1 commit into from
Jan 12, 2020

Conversation

keshavsethi
Copy link
Member

Fixes #1194
This is pull request for First timers issue 1194 where margin between buttons is added.
Thanks!

@welcome
Copy link

welcome bot commented Jan 12, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented Jan 12, 2020

Code Climate has analyzed commit 1fe6d7c and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also post a screenshot of your change?

@VladimirMikulic
Copy link
Contributor

It's a common practice when you send a UI change that it includes a screenshot showcasing the change. Thanks.

@keshavsethi
Copy link
Member Author

Sure, here it is
Screenshot from 2020-01-13 01-00-36

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@VladimirMikulic
Copy link
Contributor

@cesswairimu we can merge this 🎉

@keshavsethi
Copy link
Member Author

can you suggest me more issues which i can try??
Thanks

@VladimirMikulic
Copy link
Contributor

Hi @keshavsethi. I am glad that you are interested in contributing to PublicLab.
Are you willing to do more FTOs or you want to try some more challenging issues :)

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #1195 into main will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   72.92%   73.28%   +0.35%     
==========================================
  Files          40       40              
  Lines        1400     1400              
==========================================
+ Hits         1021     1026       +5     
+ Misses        379      374       -5
Impacted Files Coverage Δ
lib/exporter.rb 94.17% <0%> (+2.24%) ⬆️

@cesswairimu
Copy link
Collaborator

Thanks you both 💯 @keshavsethi welocme to mapknitter

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎉 🎉

@cesswairimu cesswairimu merged commit b739edf into publiclab:main Jan 12, 2020
@welcome
Copy link

welcome bot commented Jan 12, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@keshavsethi
Copy link
Member Author

Hi @keshavsethi. I am glad that you are interested in contributing to PublicLab.
Are you willing to do more FTOs or you want to try some more challenging issues :)

I have done few FTOs in plots2 as well so I think i can try some challenging issues:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTA buttons squished on multiple lines
3 participants