Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: "Create a collection" button #1188

Merged
merged 1 commit into from
Jan 6, 2020
Merged

ADD: "Create a collection" button #1188

merged 1 commit into from
Jan 6, 2020

Conversation

VladimirMikulic
Copy link
Contributor

@VladimirMikulic VladimirMikulic commented Jan 6, 2020

Is this something that you had in mind? Here is my button:

Screenshot_20200106_230218

Clicking on the button displays the modal with a message:

Screenshot_20200106_230244

Resolves #808

@ananyaarun @cesswairimu @jywarren could you take a look at this? Thanks.

@codeclimate
Copy link

codeclimate bot commented Jan 6, 2020

Code Climate has analyzed commit 4ca71d7 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #1188 into main will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   72.92%   73.28%   +0.35%     
==========================================
  Files          40       40              
  Lines        1400     1400              
==========================================
+ Hits         1021     1026       +5     
+ Misses        379      374       -5
Impacted Files Coverage Δ
lib/exporter.rb 94.17% <0%> (+2.24%) ⬆️

@jywarren
Copy link
Member

jywarren commented Jan 6, 2020

Oh wow that is AWESOME! This is great! Is it ready for a merge?

@jywarren
Copy link
Member

jywarren commented Jan 6, 2020

It sure seems so!

@jywarren jywarren merged commit 4f11b9e into publiclab:main Jan 6, 2020
@VladimirMikulic
Copy link
Contributor Author

@cesswairimu @ananya could you approve this task on GCI dashboard? Thanks.

@publiclab publiclab deleted a comment from VladimirMikulic Jan 7, 2020
@cesswairimu
Copy link
Collaborator

done...thanks for working on this

@VladimirMikulic
Copy link
Contributor Author

@cesswairimu thank you 👍

@jywarren
Copy link
Member

jywarren commented Jan 7, 2020

Just noting that an extra "this is ready" is nice because we actually encourage folks to upload their PRs early for feedback, and just to show others that the issue is being worked on already, so there's no duplication of efforts! No big deal just thought that might be helpful info!

@VladimirMikulic
Copy link
Contributor Author

@jywarren thanks, I'll do that in the future 👍 I usually submit the PR once it is ready for merge, not before that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create a collection" button on view page
3 participants