-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: "Create a collection" button #1188
ADD: "Create a collection" button #1188
Conversation
Resolves #808
Code Climate has analyzed commit 4ca71d7 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
+ Coverage 72.92% 73.28% +0.35%
==========================================
Files 40 40
Lines 1400 1400
==========================================
+ Hits 1021 1026 +5
+ Misses 379 374 -5
|
Oh wow that is AWESOME! This is great! Is it ready for a merge? |
It sure seems so! |
@cesswairimu @ananya could you approve this task on GCI dashboard? Thanks. |
done...thanks for working on this |
@cesswairimu thank you 👍 |
Just noting that an extra "this is ready" is nice because we actually encourage folks to upload their PRs early for feedback, and just to show others that the issue is being worked on already, so there's no duplication of efforts! No big deal just thought that might be helpful info! |
@jywarren thanks, I'll do that in the future 👍 I usually submit the PR once it is ready for merge, not before that. |
Is this something that you had in mind? Here is my button:
Clicking on the button displays the modal with a message:
Resolves #808
@ananyaarun @cesswairimu @jywarren could you take a look at this? Thanks.