-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix navigation search bar styling #1179
Fix navigation search bar styling #1179
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 72.92% 72.92%
=======================================
Files 40 40
Lines 1400 1400
=======================================
Hits 1021 1021
Misses 379 379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greyGroot great job! Welcome to PublicLab 🎉
@jywarren we can integrate this in the codebase. |
This is amazing 💯 Thanks for working on this @greyGroot and Thanks @VladimirMikulic for the fto and reviews. @greyGroot I see so many commits on the PR...could you please rebase and push back? up also kindly attach a screenshot if possible. Let me kow if you need any help rebasing. Thanks all |
Looks fine to me! It would help if the comments can be cleaned up and add a screenshot. Other than that, this is definitely ready for a merge! |
Code Climate has analyzed commit b805ac5 and detected 0 issues on this pull request. View more on Code Climate. |
I will rebase this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 🎉
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixes #1178
All changes has been made according to issue description.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!