Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation search bar styling #1179

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Fix navigation search bar styling #1179

merged 1 commit into from
Jan 17, 2020

Conversation

greyGroot
Copy link
Contributor

@greyGroot greyGroot commented Dec 30, 2019

Fixes #1178

All changes has been made according to issue description.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Dec 30, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #1179 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files          40       40           
  Lines        1400     1400           
=======================================
  Hits         1021     1021           
  Misses        379      379

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greyGroot great job! Welcome to PublicLab 🎉

@VladimirMikulic
Copy link
Contributor

@jywarren we can integrate this in the codebase.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Dec 31, 2019

This is amazing 💯 Thanks for working on this @greyGroot and Thanks @VladimirMikulic for the fto and reviews. @greyGroot I see so many commits on the PR...could you please rebase and push back? up also kindly attach a screenshot if possible. Let me kow if you need any help rebasing. Thanks all

@LeoDog896
Copy link

Looks fine to me! It would help if the comments can be cleaned up and add a screenshot. Other than that, this is definitely ready for a merge!

@codeclimate
Copy link

codeclimate bot commented Jan 17, 2020

Code Climate has analyzed commit b805ac5 and detected 0 issues on this pull request.

View more on Code Climate.

@cesswairimu
Copy link
Collaborator

I will rebase this

@cesswairimu
Copy link
Collaborator

Screenshot from 2020-01-17 18-57-20

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 🎉

@cesswairimu cesswairimu merged commit b3a4f51 into publiclab:main Jan 17, 2020
@welcome
Copy link

welcome bot commented Jan 17, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent styling across PL projects
4 participants