Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs reporting with Rails 4 upgrade #668

Closed
cesswairimu opened this issue Jun 5, 2019 · 32 comments
Closed

Bugs reporting with Rails 4 upgrade #668

cesswairimu opened this issue Jun 5, 2019 · 32 comments
Labels
discussion support

Comments

@cesswairimu
Copy link
Collaborator

I am finishing up with Rails 4.2 upgrade #578 ... calling for people to test the upgraded version on unstable http://mapknitter-unstable.laboratoriopublico.org/ and please comment below if you find any bugs thanks.
@cesswairimu cesswairimu mentioned this issue Jun 5, 2019
Closed
@alaxalves
Copy link
Member

OMG, I did not know that this was on unstable already 😄 😄 😄 😄

@kaustubh-nair
Copy link
Member

@kaustubh-nair
Copy link
Member

Let's create new issues for any bug that turns up? I can help out with the issues too

@kaustubh-nair
Copy link
Member

kaustubh-nair commented Jun 6, 2019 •
edited
Loading

Just realized the login problem is because unstable has some commits ahead of main that don't work
https://github.com/publiclab/mapknitter/network
@jywarren Should we reset unstable to match with main?

@jywarren
Copy link
Member

jywarren commented Jun 6, 2019 via email

@cesswairimu
Copy link
Collaborator Author

Thanks @kaustubh-nair yeah we can have issues for the failing parts and yeah you can go ahead and work on that. Also on the unstable part having commits ahead of main is because now unstable have the commits on #578 which we are now testing

@alaxalves
Copy link
Member

Ok cool, so @kaustubh-nair will keep tracking bugs with 4.2 version and will keep his good work at #357. I'll get #667 merged then start working on the 4.2 ~> 5.1.6 upgrade. And @cesswairimu are you going to keep working with us on the upgrades or are going for different issues?

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Jun 6, 2019 •
edited
Loading

Sounds good..and yeah I will keep working with you on the upgrade until rails 4.2 upgrade is done then you guys can take over. Thanks

@cesswairimu
Copy link
Collaborator Author

@kaustubh-nair I just fixed the login error could you please try again on unstable when you get a minute? Thanks

@coderjolly
Copy link
Member

@kaustubh-nair I just fixed the login error could you please try again on unstable when you get a minute? Thanks

I was jst trying it, the error still persists (its nt really an error, bt the site doesn't respond aftr clicking on Google sign-in)

@cesswairimu
Copy link
Collaborator Author

mmmh thats weird because it logs me in...@coderjolly did you try any of the other sign-in via methods and did any work? Thanks for taking a look

@coderjolly
Copy link
Member

mmmh thats weird because it logs me in...@coderjolly did you try any of the other sign-in via methods and did any work? Thanks for taking a look

Sure, I am free with my exams now and will see these. 👍

@cesswairimu
Copy link
Collaborator Author

Awesome! Thanks

@kaustubh-nair kaustubh-nair mentioned this issue Jun 10, 2019
Open
5 tasks
@jywarren
Copy link
Member

jywarren commented Jun 21, 2019 •
edited
Loading

Hi all - Jenkins says our stable server (http://mapknitter-stable.laboratoriopublico.org/)has been down for the past week -- here's the last successful build: https://jenkins.laboratoriopublico.org/job/Mapknitter-Stable/lastSuccessfulBuild/console

No worries, just getting synced up here.

https://jenkins.laboratoriopublico.org/job/Mapknitter-Stable/lastFailedBuild/console is the most recent failed build, which right now shows:

�[1Bdocker-compose exec -T web bash -l -c "sleep 10 && rake db:migrate && rake assets:precompile"
mesg: ttyname failed: Inappropriate ioctl for device
rake aborted!
Mysql2::Error: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory")
/usr/local/bundle/gems/mysql2-0.3.21/lib/mysql2/client.rb:70:in `connect'
/usr/local/bundle/gems/mysql2-0.3.21/lib/mysql2/client.rb:70:in `initialize'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/mysql2_adapter.rb:18:in `new'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/mysql2_adapter.rb:18:in `mysql2_connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:438:in `new_connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:448:in `checkout_new_connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:422:in `acquire_connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:349:in `block in checkout'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:348:in `checkout'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:263:in `block in connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:262:in `connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:571:in `retrieve_connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_handling.rb:113:in `retrieve_connection'
/usr/local/bundle/gems/activerecord-4.2.11.1/lib/active_record/connection_handling.rb:87:in `connection'
/app/config/initializers/column_definition.rb:19:in `<class:ColumnDefinition>'
/app/config/initializers/column_definition.rb:17:in `<top (required)>'
/usr/local/bundle/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:268:in `load'
/usr/local/bundle/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:268:in `block in load'
/usr/local/bundle/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:240:in `load_dependency'
/usr/local/bundle/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:268:in `load'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/engine.rb:652:in `block in load_config_initializer'
/usr/local/bundle/gems/activesupport-4.2.11.1/lib/active_support/notifications.rb:166:in `instrument'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/engine.rb:651:in `load_config_initializer'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/engine.rb:616:in `block (2 levels) in <class:Engine>'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/engine.rb:615:in `each'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/engine.rb:615:in `block in <class:Engine>'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/initializable.rb:30:in `instance_exec'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/initializable.rb:30:in `run'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/initializable.rb:55:in `block in run_initializers'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/initializable.rb:44:in `each'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/initializable.rb:44:in `tsort_each_child'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/initializable.rb:54:in `run_initializers'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/application.rb:352:in `initialize!'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/railtie.rb:194:in `public_send'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/railtie.rb:194:in `method_missing'
/app/config/environment.rb:5:in `<top (required)>'
/usr/local/bundle/gems/skylight-core-4.1.0/lib/skylight/core/probes.rb:118:in `require'
/usr/local/bundle/gems/skylight-core-4.1.0/lib/skylight/core/probes.rb:118:in `require'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/application.rb:328:in `require_environment!'
/usr/local/bundle/gems/railties-4.2.11.1/lib/rails/application.rb:457:in `block in run_tasks_blocks'

I know folks are working on a database issue with Rails 5, but just looking to see what the latest status is on the main branch and track it in one place. I'd like to publish our code to the live site pretty soon so if you could offer an update on what's being worked on and what needs fixing, that'd be great! Thanks all!

cc @cesswairimu @alaxalves @kaustubh-nair @divyabaid16 @rarrunategu1

@kaustubh-nair
Copy link
Member

Oh wow I didn't notice this at all. So the yarn upgrade didn't get published to the live site? I'm surprised the Travis build didn't fail for it. I'm sure the problem is due to the database.yml that I had modified for getting it running on travis. I'll revert it to what it was.
Meanwhile @jywarren @alaxalves Is there a reason the Travis build is passing but jenkins is failing? Perhaps because of different environments?

@kaustubh-nair
Copy link
Member

The only reported bug right now is #728
Once we fix that we should be good!
Thanks!

@alaxalves
Copy link
Member

Oh wow I didn't notice this at all. So the yarn upgrade didn't get published to the live site? I'm surprised the Travis build didn't fail for it. I'm sure the problem is due to the database.yml that I had modified for getting it running on travis. I'll revert it to what it was.
Meanwhile @jywarren @alaxalves Is there a reason the Travis build is passing but jenkins is failing? Perhaps because of different environments?

I have set Travis to start using Test env, since it was using Production's. Maybe Jenkins have not been set to use the same env.

@jywarren
Copy link
Member

Hi @alaxalves can you point at or elaborate on the change we'll need to make in Jenkins, so when @icarito has a second it'll be easy to make the changes? Thanks a lot! And thanks @kaustubh-nair i'll watch for #728 and we'll hopefully test it on stable before doing a publication to production. We're not yet running Rails 4 or Yarn on production but hoping to this week!

@alaxalves
Copy link
Member

Hi @alaxalves can you point at or elaborate on the change we'll need to make in Jenkins, so when @icarito has a second it'll be easy to make the changes? Thanks a lot! And thanks @kaustubh-nair i'll watch for #728 and we'll hopefully test it on stable before doing a publication to production. We're not yet running Rails 4 or Yarn on production but hoping to this week!

I can do that, currently I am a little unaware of what is going on with Jenkins but I'll catch up with Kaustubh.

@jywarren
Copy link
Member

jywarren commented Jun 24, 2019 via email

@jywarren
Copy link
Member

Any updates here? Thanks a lot!

@kaustubh-nair
Copy link
Member

Mapknitter stable is up now that we fixed database.yml
We've got 2 small asset loading issues here #742 #734 that we need to fix

@alaxalves
Copy link
Member

Mapknitter stable is up now that we fixed database.yml
We've got 2 small asset loading issues here #742 #734 that we need to fix

This is going very well, right now I'm investigating an issue with Rubocop here that has recently popped up when I was setting the cache configs for bundle. I know this is related to gem versions, and I think I might have fixed it on Rails 5 MR, BTW I am also working on the deprecation warnings that have appeared.

@jywarren
Copy link
Member

jywarren commented Jun 28, 2019 via email

@cesswairimu
Copy link
Collaborator Author

cesswairimu commented Jun 28, 2019 •
edited
Loading

I think its a great idea...The build on main has been failing since eca473a though should we revert this before publishing or it shouldn't affect it?

@kaustubh-nair
Copy link
Member

Sure let's do it!
I found a new bug here because of which map creation does not work, but I'm not sure if it is happening to everyone #759

@cesswairimu
Copy link
Collaborator Author

Yeah I had the same bug as well...I fixed that with 6941c1e I believe it should be good now

@alaxalves
Copy link
Member

I'm starting to think we should publish the latest main branch to the live site today or monday! What do folks think?
…
On Thu, Jun 27, 2019 at 8:59 AM Álax de Carvalho Alves < @.***> wrote: Mapknitter stable is up now that we fixed database.yml We've got 2 small asset loading issues here #742 <#742> #734 <#734> that we need to fix This is going very well, right now I'm investigating an issue with Rubocop here <#751> that has recently popped up when I was setting the cache configs for bundle. I know this is related to gem versions, and I think I might have fixed it on Rails 5 MR <#685>, BTW I am also working on the deprecation warnings that have appeared. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668?email_source=notifications&email_token=AAAF6J75ERUU2JMM4XOEPQLP4S2QJA5CNFSM4HUF6I5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXA6WQ#issuecomment-506335066>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZ3YPLIOOYHETKMX6TP4S2QJANCNFSM4HUF6I5A .

This is great, just in time. BTW @jywarren @sashadev-sky @kaustubh-nair I have finished with Rails 5 upgrade at: #685. I'm only missing a step on Travis and bundle caching integration. Besides that I have finished with all the deprecation warnings and tests. It will be available to push to unstable in short time.

@jywarren
Copy link
Member

jywarren commented Jun 28, 2019 via email

@jywarren
Copy link
Member

jywarren commented Jun 28, 2019 via email

@alaxalves
Copy link
Member

Hmm, I think we'd best address all critical bugs with rails 4 on main branch to publish to live, and hold off on merging rails 5 to main until there are a few more days to test it out. Can folks look into the map creation bug and if we can resolve that first we can call it a release and publish to live? Thanks!!! On Fri, Jun 28, 2019, 2:21 PM Álax de Carvalho Alves < notifications@github.com> wrote:
…
I'm starting to think we should publish the latest main branch to the live site today or monday! What do folks think? … <#m_1252459800365418611_> On Thu, Jun 27, 2019 at 8:59 AM Álax de Carvalho Alves < @.***> wrote: Mapknitter stable is up now that we fixed database.yml We've got 2 small asset loading issues here #742 <#742> <#742 <#742>> #734 <#734> <#734 <#734>> that we need to fix This is going very well, right now I'm investigating an issue with Rubocop here <#751 <#751>> that has recently popped up when I was setting the cache configs for bundle. I know this is related to gem versions, and I think I might have fixed it on Rails 5 MR <#685 <#685>>, BTW I am also working on the deprecation warnings that have appeared. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668 <#668>?email_source=notifications&email_token=AAAF6J75ERUU2JMM4XOEPQLP4S2QJA5CNFSM4HUF6I5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXA6WQ#issuecomment-506335066>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZ3YPLIOOYHETKMX6TP4S2QJANCNFSM4HUF6I5A . This is great, just in time. BTW @jywarren https://github.com/jywarren @sashadev-sky https://github.com/sashadev-sky @kaustubh-nair https://github.com/kaustubh-nair I have finished with Rails 5 upgrade at: #685 <#685>. I'm only missing a step on Travis and bundle caching integration. Besides that I have finished with all the deprecation warnings and tests. It will be available to push to unstable in short time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#668?email_source=notifications&email_token=AAAF6J4RKT5XXQSZU6OGCM3P4ZJCFA5CNFSM4HUF6I5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY22IZA#issuecomment-506831972>, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6S5YMNM2UYSFBZNIDP4ZJCFANCNFSM4HUF6I5A .

I totally agree with, but actually I meant merging Rails 5 to development branch and then to unstable 😄 😄

@cesswairimu
Copy link
Collaborator Author

I believe we are doing great with rails 4. closing this now. Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jywarren @cesswairimu @alaxalves @coderjolly @kaustubh-nair