Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create config.yml #67

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Create config.yml #67

merged 3 commits into from
Oct 24, 2018

Conversation

faithngetich
Copy link
Contributor

@faithngetich faithngetich commented Oct 12, 2018 •
edited
Loading

Issue link

Rishabh570
Rishabh570 approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@Rishabh570 Rishabh570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sagarpreet-chadha
sagarpreet-chadha approved these changes Oct 13, 2018
View reviewed changes
Copy link
Collaborator

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME 🎉 !!!

jywarren
jywarren requested changes Oct 17, 2018
View reviewed changes
@faithngetich
Copy link
Contributor Author

@jywarren I have accepted the changes you request but I have a concern. The link returns a 404 error when I try to access it. Do you have an idea why this is the case?

jywarren
jywarren requested changes Oct 23, 2018
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, i'm sorry - here's the full link!! My fault.

@jywarren @faithngetich
Add the specific leaflet-environmental-layers link
e1154aa 
Co-Authored-By: faithngetich <faithngetich188@gmail.com>
@faithngetich
Copy link
Contributor Author

@jywarren done.

@jywarren jywarren merged commit 442a1bc into publiclab:master Oct 24, 2018
@jywarren
Copy link
Member

Awesome, thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren requested changes

@sagarpreet-chadha sagarpreet-chadha sagarpreet-chadha approved these changes

@Rishabh570 Rishabh570 Rishabh570 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faithngetich @jywarren @sagarpreet-chadha @Rishabh570