Adding legends #104
Merged
Adding legends #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagarpreet-chadha How does this look? |
|
@jywarren ...what do you think ? Also i have approved this task on GCI dashboard . |
|
Hi @kevinzluo @sagarpreet-chadha as it's near completion, how about resolving conflicts and getting it merged. Thanks! |
c3c5b30 to
0295a76
Compare
|
@gauravano Resolved now 😄 |
|
Oh, i'm sorry - needs one more rebase as we've merged in some new material. Apologies!!! |
|
Sorry this took me so long! Rebasing and getting ready to merge! |
General solution with image links hosted from own repo
7caf0c4 to
3ea6561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103 .
I have implemented a general control for the layers along with other functionality. Now any legend may be added with the syntax
addLayerNameURLPair( layer_var, img_url ). Thelayer_varmust be conistent with the one used inindex.html.I have placed my
srcfiles in a new folder calledutilsince they were not really layers.Example of working:
