-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size spec added and new template added using BlurredLocation object #7
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
f6921cb
new example using object added
mridulnagpal d7696ad
size spec added
mridulnagpal d7a4617
small tweaks
mridulnagpal b78d5ea
README updated
mridulnagpal c29e827
README updated
mridulnagpal 138b289
Update README.md
mridulnagpal d05e6ef
Update README.md
mridulnagpal ab651be
Update README.md
mridulnagpal f70fc71
README updated
mridulnagpal 42c8f43
README updated
mridulnagpal 0124158
README updated
mridulnagpal b7b9ac7
Size removed
mridulnagpal 1a486dc
options added
mridulnagpal b62fa04
object.js changed
mridulnagpal 51d742c
merge conflict
mridulnagpal 4c0c13a
addgrid working
mridulnagpal 32cb2fb
README updated
mridulnagpal 363190f
tweaks
mridulnagpal 8bfa37c
changes in Gruntfile
mridulnagpal 0af7deb
js file updated
mridulnagpal 655845e
renaming examples
mridulnagpal f1d554e
Test passing
mridulnagpal 81efadc
Structuring the library
mridulnagpal e345dca
Restructuring dist/built.js
mridulnagpal 0c49afb
Renaming and using geocode function inside of panMapToGeocodedLocation()
mridulnagpal 54cb90e
Removing redundancies
mridulnagpal 1bbab6b
Renaming function
mridulnagpal c289926
Little tweaks to clean code
mridulnagpal f5fd39a
tweaks
mridulnagpal 9b3507f
tweaks
mridulnagpal d51c63c
Making global methods internal
mridulnagpal 642ab51
Test passing
mridulnagpal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and I assume it's needed for some of the other functions. But let's keep in mind what is essential API that cannot be provided by direct access to the map, such as a native Leaflet call (not sure but probably
map.getSize()
?) Can this be done here without a redundant wrapper, or isgetSize
really necessary for the API? Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it would be necessary, should I remove it then?