reworking GridSystem to be based on latitude precision #32
Conversation
dist/Leaflet.BlurredLocation.js
Outdated
| @@ -13379,6 +13378,27 @@ BlurredLocation = function BlurredLocation(options) { | |||
| } | |||
| } | |||
|
|
|||
| function gridWidthInPixels(degrees) { | |||
| var p1 = L.latLng(1,1); | |||
There was a problem hiding this comment.
Here, we can't just use 1,1 because that's a specific place on the map. We have to start with the current center -- so getLat() and getLon(), then add to those. It'll change based on where in the world you are, remember?
There was a problem hiding this comment.
Yeah , replaced the 1's with functions
dist/Leaflet.BlurredLocation.js
Outdated
| @@ -13391,6 +13411,8 @@ BlurredLocation = function BlurredLocation(options) { | |||
| panMapWhenInputsChange: panMapWhenInputsChange, | |||
| panMap: panMap, | |||
| panMapByBrowserGeocode: panMapByBrowserGeocode, | |||
| gridWidthInPixels: gridWidthInPixels, | |||
There was a problem hiding this comment.
Also, these can be internal functions. They don't need an external API; that'll be getPrecision, later.
There was a problem hiding this comment.
I actually added them for testing, removing them.
|
Also let's add a |
|
For truncate, maybe we can just use a module: https://www.npmjs.com/search?q=truncate |
src/core/gridSystem.js
Outdated
| @@ -23,7 +23,7 @@ module.exports = function addGrid(map, onChangeLocation) { | |||
| include: L.Mixin.Events, | |||
|
|
|||
| options: { | |||
| cellSize: 64, | |||
| cellSize: 40, | |||
There was a problem hiding this comment.
OK, so here you'd want to either use something like options.cellSize and have it settable via the constructor (like options.map, above), OR you could make addGrid have a method called addGrid.setCellSize(degreesWide, degreesTall)
|
@jywarren Please have a look made the changes |
| @@ -13315,7 +13318,7 @@ BlurredLocation = function BlurredLocation(options) { | |||
| return options.map.getSize(); | |||
| } | |||
|
|
|||
| addGrid = options.addGrid; | |||
| gridSystem = options.gridSystem; | |||
There was a problem hiding this comment.
Is this necessary? I guess we can just refer to it by options.GridSystem, no?
There was a problem hiding this comment.
We can just use options.systemGrid removing it
|
OK, this looks good -- why don't we merge it and then do another one where you create a method called: options.gridSystem.setCellSizeInDegrees(degrees);And let's rename var degrees = getMinimumGridWidth(100).degrees;
options.gridSystem.setCellSizeInDegrees(degrees);Makes sense? |
|
Once we do this, we'll need to modify GridSystem to be drawing the grid accordingly, and we can test it out. |
|
Cool, merging this one and working on the new methods |
#18