lat lon when entered changes the map location #25
Conversation
|
@jywarren Please have a look will post separate PR's for separate issues from now on. |
|
Ok but why is some code commented out? It seems unrelated to the PR title?
…On Jun 17, 2017 7:00 AM, "Mridul Nagpal" ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Please have a look will post
separate PR's for separate issues from now on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7WZ306kXiaep85mgbTF1amVa3_fks5sE7D2gaJpZM4N9Me9>
.
|
|
@jywarren We have not added google as a property yet, thus it shows an error. As soon as we reach that part I will uncomment it so that it shows no errors |
|
Can you create an issue for that and then merge this? |
|
@jywarren I think we have the google API we just need to uncomment the method |
Merge branch 'master' of https://github.com/publiclab/leaflet-blurred-location into fix-subhandler
|
@jywarren No more conflicts |
There was a problem hiding this comment.
Oops I think your merges left a couple unmerged lines and also some various indentation changes we may not need. At this point you may want to manually copy in the changes since there are only a few.
For one I noticed you removed the leaflet inclusion -- I did that here instead of in browserify, so we can control it's scope a bit more.
|
On it |
|
@jywarren Done have a look |
|
Looks good, no? Go ahead and merge! But we haven't tested the function the PR names -- I think for that we have to actually write a test that sets the value of the input and sends a "change" event, then tests if the map has changed. I'll make a new issue. |
solves #23