Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Nightly Completed #893

Merged
merged 7 commits into from
Mar 19, 2019
Merged

Is Nightly Completed #893

merged 7 commits into from
Mar 19, 2019

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Mar 19, 2019

Fixes #857

Add links to https://beta.sequencer.publiclab.org where daily/nightly builds are now going to be published!

Removed module.js and info.json files added to the root / directory by mistake in exposure module pr.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshkhandeparkar
Copy link
Member Author

@jywarren

@harshkhandeparkar
Copy link
Member Author

@publiclab/is-reviewers

@jywarren jywarren merged commit f852730 into main Mar 19, 2019
@jywarren
Copy link
Member

Nice!

@harshkhandeparkar harshkhandeparkar deleted the is-beta branch March 19, 2019 14:25
@harshithpabbati
Copy link

@harshkhandeparkar i made the script to run but see there is some error see in the chrome tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants