Added the resize quick button #782

harshithpabbati · 2019-02-16T13:29:58Z

Fixes #499

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

harshithpabbati · 2019-02-16T13:30:18Z

@publiclab/is-reviewers

harshithpabbati · 2019-02-16T13:31:24Z

@harshkhandeparkar checkout this..

harshkhandeparkar

Please tell me the name of the fontawesome icon you are using.

harshkhandeparkar · 2019-02-16T13:32:26Z

examples/index.html

  <footer>
    <hr style="margin:20px;"><center><a class="color:grey;" id="clear-cache">Clear offline cache</a></center>
+    <div class="row">


I think you have made this branch from your footer branch and not from main. Please remove these changes(footer)

harshkhandeparkar · 2019-02-16T13:33:19Z

examples/index.html

@@ -86,6 +86,12 @@ <h1><a href="/" target='_blank' class="name-header">Image Sequencer</a></h1>
          </div>
          <p class="info">Select a new module to add to your sequence.</p>
          <div class="row center-align radio-group">
+            <div>
+              <div class="radio" data-value="resize">
+                <i class="icon-resize-full fa-4x i-over"></i>


You have to add the classes fa fa-4x i-over and fa-name-of-icon. Do you have any other difficulty?

harshkhandeparkar · 2019-02-16T13:33:34Z

examples/lib/intermediateHtmlStepUi.js

@@ -10,6 +10,12 @@ function IntermediateHtmlStepUi(_sequencer, step, options) {
            <div class="panel-body">\
              <p class="info">Select a new module to add to your sequence.</p>\
              <div class="row center-align radio-group">\
+              <div>\
+              <div class="radio" data-value="resize">\
+              <i class="fa icon-resize-full fa-4x"></i>\


harshkhandeparkar · 2019-02-16T13:35:53Z

Also you have to build the dist riles by first running grunt browserify and then grunt uglify and please commit those files.

Divy123 · 2019-02-16T13:41:28Z

@harshithpabbati please provide a screenshot or gif .
Also as said by HarshKhandeparkar please checkout main branch then make a new branch suppose add-resize and make the said changes there.
Please keep this rule with you new PR by new branch always.
Thanks!

harshkhandeparkar · 2019-02-16T13:42:59Z

@Divy123 @harshithpabbati I don't think there is a need to checkout main, just remove the footer.

Divy123 · 2019-02-16T13:48:37Z

@harshkhandeparkar this a rule which I said that new PR by new branch.

harshkhandeparkar · 2019-02-16T13:49:49Z

Divy123 this is a new branch, it is just branched from the footer branch so it has those changes.

harshithpabbati · 2019-02-16T13:50:23Z

I will remove the footer and send it to you

Divy123 · 2019-02-16T13:50:52Z

Also @harshithpabbati something I want to know from you that if you have created a new branch resize by remaining on footer branch.
I think that may be the case because of that only your footer changes are visible.
So the order is always checkout main from your current branch before making changes that will result into a new PR

harshithpabbati · 2019-02-16T13:52:08Z

Yeah i did it by mistake i didn't see it

Divy123 · 2019-02-16T13:52:47Z

@harshithpabbati donl't do this as this is not a good practice.
Please checkout to the main and then do checkout a new branch so that no any unexpected changes may happen.

harshkhandeparkar · 2019-02-16T13:54:22Z

@harshithpabbati when you create a new branch, it is branched from the branch that is currently checked out. Always checkout main before branching. Also keep main up to date. If you are using the git tab of a code editor like atom or vscode then it normally asks which branch to branch from. Always choose HEAD branch. Thanks.

jywarren · 2019-02-16T14:15:33Z

This is looking great! I just needed resize recently while working with an image and thought how useful a quick button would be. Don't worry you'll get the hang of branch management sooner enough, it's a pain at first but you get used to it. Thanks to everyone for helping out, and thanks for contributing this code! 👍🏽👍🏽🙌🏽

…

On Sat, Feb 16, 2019, 7:54 AM Harsh Khandeparkar ***@***.*** wrote: @harshithpabbati <https://github.com/Harshithpabbati> when you create a new branch, it is branched from the branch that is currently checked out. Always checkout main before branching. Also keep main up to date. If you are using the git tab of a code editor like atom or vscode then it normally asks which branch to branch from. Always choose HEAD branch. Thanks. — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#782 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ1A3m_gD5nEJM3d_3eNEyWsZ2arbks5vOA2PgaJpZM4a-_Pz> .

harshithpabbati · 2019-02-16T14:23:50Z

How do I edit it??Do I close the request and send a new pr??

harshkhandeparkar · 2019-02-16T14:26:38Z

You can commit to the branch and the changes will be visible here.

harshithpabbati · 2019-02-16T14:29:20Z

even though i added the font awesome icons i can't get the icon

harshkhandeparkar · 2019-02-16T14:30:06Z

Can you please commit the changes?

harshithpabbati · 2019-02-16T14:34:11Z

@harshkhandeparkar made the commit

harshithpabbati · 2019-02-16T15:19:13Z

This was the changes which I made.But can't get the image in it's place

harshkhandeparkar · 2019-02-16T15:26:46Z

I don't think this is your problem. @Divy123 the preview is not loading. Can you please look into it?

harshithpabbati · 2019-02-16T15:31:22Z

I don't think this is your problem. @Divy123 the preview is not loading. Can you please look into it?

Checkout this @harshkhandeparkar

harshkhandeparkar · 2019-02-16T15:33:37Z

Yes, exactly the preview image behind the icon is not loading. @Divy123 please look into this.

Divy123 · 2019-02-16T16:03:30Z

@harshithpabbati you need to do just one thing.
Navigate to the image-sequencer/examples/lib/insertPreview file and at the line number 33 inside previewSequencerSteps
you need to add resize:"125%" .
I think that should do.
Thanks !
Please feel free to ask in case you need any help.

harshithpabbati · 2019-02-16T16:21:16Z

@harshithpabbati you need to do just one thing.
Navigate to the image-sequencer/examples/lib/insertPreview file and at the line number 33 inside previewSequencerSteps
you need to add resize:"125%" .
I think that should do.
Thanks !
Please feel free to ask in case you need any help.

thanks for the help @Divy123

harshithpabbati · 2019-02-16T17:24:18Z

Done with all the changes.

Divy123 · 2019-02-16T17:28:22Z

@harshithpabbati screenshot please.

harshithpabbati · 2019-02-16T17:31:09Z

Divy123 · 2019-02-16T17:45:01Z

Please do grunt build

harshkhandeparkar · 2019-02-16T17:45:48Z

Please run grunt browserify and grunt uglify and commit the changes.

harshkhandeparkar · 2019-02-16T17:47:01Z

@Divy123 currently grunt build does not build the ui files.

Divy123 · 2019-02-16T17:47:31Z

Oh my bad!
Thanks @harshkhandeparkar .

harshithpabbati · 2019-02-16T17:52:03Z

Please run grunt browserify and grunt uglify and commit the changes.

Yeah i did it before using npm start and even did it now.

harshkhandeparkar · 2019-02-16T18:15:29Z

You have yo commit the files inside dist/ folder after running the grunt commands. You have to run the grunt commands each time you touch a js file. Thanks.

harshithpabbati · 2019-02-16T18:53:30Z

@publiclab/is-reviewers done with the changes.

harshkhandeparkar

Awesome!

harshithpabbati · 2019-02-17T15:37:28Z

@publiclab/is-reviewers

harshkhandeparkar · 2019-02-17T17:01:57Z

Your PR has been reviewed already and is ready to merge. When jywarren sees your PR next time , he will merge it(after a final review). According to his time, now will be the beginning of a sunday so you will have to wait for another 24hrs before it gets merged. Thanks!

harshithpabbati · 2019-02-17T17:04:10Z

Oh ok fine

harshithpabbati · 2019-02-17T17:05:07Z

I have a doubt how can i join into the reviewers team??

harshkhandeparkar · 2019-02-17T17:08:06Z

Jywarren is really busy since he has to look after all the projects of publiclab. The biggest project i.e. plots2 has more than 100 PRs open so its really difficult for him to reply to all the questions. I hope you understand.

harshkhandeparkar · 2019-02-17T18:12:08Z

I have a doubt how can i join into the reviewers team??

There are some prerequisites mentioned in #656 and you have to be well acquainted with the codebase and have to have some experience working with the publiclab community.

welcome · 2019-02-18T00:16:19Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://sequencer.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

jywarren · 2019-02-18T00:16:32Z

Great work here!!! Thanks so much!

jywarren · 2019-02-18T00:17:03Z

And we'd love to have more contributions from you! 🎉🙌🏽

harshithpabbati · 2019-02-18T05:28:45Z

And we'd love to have more contributions from you! 🙌🏽

Sure @jywarren

Added the resize module

d2b4217

harshkhandeparkar requested changes Feb 16, 2019

View reviewed changes

harshkhandeparkar changed the title ~~Added the resize module~~ Added the resize quick button Feb 16, 2019

Added the resize quick button

dbef2fd

Made the icon to fit into the box

349d078

Added the footer to the main page

3df09de

Divy123 approved these changes Feb 16, 2019

View reviewed changes

Added the resize quick button

f8bf9b6

harshkhandeparkar approved these changes Feb 17, 2019

View reviewed changes

harshkhandeparkar added the ready-to-merge label Feb 17, 2019

jywarren approved these changes Feb 18, 2019

View reviewed changes

jywarren merged commit fdb38f7 into publiclab:main Feb 18, 2019

This was referenced Feb 18, 2019

Call for reviewers and co-reviewing workflow ⚡️ publiclab/plots2#4707

Open

Call for reviewers group and new co-reviewing workflow #656

Open

This was referenced Mar 6, 2019

Call for Summer of Code 2019 mentors! publiclab/plots2#4585

Closed

Add Resize Quick Button #699

Closed

Added the resize quick button #782

Added the resize quick button #782

Conversation

harshithpabbati commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshkhandeparkar left a comment

Choose a reason for hiding this comment

harshkhandeparkar Feb 16, 2019

Choose a reason for hiding this comment

harshkhandeparkar Feb 16, 2019

Choose a reason for hiding this comment

harshkhandeparkar Feb 16, 2019

Choose a reason for hiding this comment

harshkhandeparkar commented Feb 16, 2019

Divy123 commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

Divy123 commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019 • edited Loading

Divy123 commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

Divy123 commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

jywarren commented Feb 16, 2019 via email

harshithpabbati commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

Divy123 commented Feb 16, 2019 • edited Loading

harshithpabbati commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

Divy123 commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

Divy123 commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

harshkhandeparkar commented Feb 16, 2019

Divy123 commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019 • edited Loading

harshkhandeparkar commented Feb 16, 2019

harshithpabbati commented Feb 16, 2019

harshkhandeparkar left a comment

Choose a reason for hiding this comment

harshithpabbati commented Feb 17, 2019

harshkhandeparkar commented Feb 17, 2019

harshithpabbati commented Feb 17, 2019

harshithpabbati commented Feb 17, 2019

harshkhandeparkar commented Feb 17, 2019

harshkhandeparkar commented Feb 17, 2019

welcome bot commented Feb 18, 2019

jywarren commented Feb 18, 2019

jywarren commented Feb 18, 2019

harshithpabbati commented Feb 18, 2019 • edited Loading

harshithpabbati commented Feb 16, 2019 •

edited

Loading

Divy123 commented Feb 16, 2019 •

edited

Loading

harshithpabbati commented Feb 16, 2019 •

edited

Loading

harshithpabbati commented Feb 18, 2019 •

edited

Loading