-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected default view for Saturation module #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I used to hate the saturation module. Once I even thought that my flipImage module was not working since the older step was saturation.
😊😊
😆 😆 sorted now ... |
Ah, is the screenshot above depicting the problem, not the solution? Can you screenshot the saturation module working correctly? Thank you @aashna27 this is great! The new defaults system will make a lot of this smoother now. |
yea this one is the problem . Solution: |
Perfect. Varun has a big open PR he doesn't want to rebase so let's give him some time. I'll mark this as ready and if you have any input on my most recent two PRs I'd love some help! |
yea .. I did comment to go forward with the benchmark one , if you would like that.Thanks |
@jywarren how about merging this one, I have rebased it. |
🎉 |
Fixes #801

Fixes the problem:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/reviewers
and@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!