Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected default view for Saturation module #772

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Corrected default view for Saturation module #772

merged 2 commits into from
Feb 21, 2019

Conversation

aashna27
Copy link

@aashna27 aashna27 commented Feb 14, 2019

Fixes #801
Fixes the problem:
image

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I used to hate the saturation module. Once I even thought that my flipImage module was not working since the older step was saturation.
😊😊

@aashna27
Copy link
Author

Awesome! I used to hate the saturation module. Once I even thought that my flipImage module was not working since the older step was saturation.
😊😊

😆 😆 sorted now ...

@jywarren
Copy link
Member

Ah, is the screenshot above depicting the problem, not the solution? Can you screenshot the saturation module working correctly? Thank you @aashna27 this is great! The new defaults system will make a lot of this smoother now.

@aashna27
Copy link
Author

Ah, is the screenshot above depicting the problem, not the solution? Can you screenshot the saturation module working correctly? Thank you @aashna27 this is great! The new defaults system will make a lot of this smoother now.

yea this one is the problem .

Solution:

ezgif com-video-to-gif 2

@jywarren
Copy link
Member

Perfect. Varun has a big open PR he doesn't want to rebase so let's give him some time. I'll mark this as ready and if you have any input on my most recent two PRs I'd love some help!

@aashna27
Copy link
Author

Perfect. Varun has a big open PR he doesn't want to rebase so let's give him some time. I'll mark this as ready and if you have any input on my most recent two PRs I'd love some help!

yea .. I did comment to go forward with the benchmark one , if you would like that.Thanks

@aashna27
Copy link
Author

@jywarren how about merging this one, I have rebased it.

@jywarren jywarren merged commit ffed3d1 into publiclab:main Feb 21, 2019
@jywarren
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants