HtmlType property in info.json files

[harshkhandeparkar]

Fixes #570

Added separate property htmlType to info.json files to make the type property more specific.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[harshkhandeparkar]

@jywarren @tech4GT please review.

[harshkhandeparkar]

@jywarren should I change the docs too?

[harshkhandeparkar]

The step toggle thing was not working so I fixed it. Was a small fix so I included it. Had to do that or otherwise, I was not able to work. I made it more efficient too!

[harshkhandeparkar]

@jywarren I found something, grunt build does not compile UI files only grunt serve does.

[harshkhandeparkar]

@jywarren I have changed the docs

https://github.com/HarshKhandeparkar/image-sequencer/blob/htmlType-in-info-files/CONTRIBUTING.md#info-file

[harshkhandeparkar]

The tests are failing. Please help me here!

[harshkhandeparkar]

@jywarren please help me with the errors.

[harshkhandeparkar]

The errors are weird. Seems like channel and blur modules are causing errors.

[harshkhandeparkar]

Those modules are having default parameters but the expected does not. How does this link to my pr?

[harshkhandeparkar]

@jywarren If I change the line

image-sequencer/src/modules/Channel/Module.js

Line 6 in c72beb7

options.channel = options.channel || "green";

to

options.channel = options.channel;

then the tests pass for the toString() part

[harshkhandeparkar]

Also the same for blur module. Why is this happening? Does this link to my PR?

[harshkhandeparkar]

My mistake sorry! I looked into the source code. The inputs need to have the min max desc etc properties as direct children. I am closing this one. Will open a new one.

[harshkhandeparkar]

Tests are passing!!

[jywarren]

oh ok, great!

…

On Thu, Jan 10, 2019 at 7:20 AM HarshKhandeparkar ***@***.***> wrote: Tests are passing!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#634 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ9jJVZ6UbYxv1SKdM_o4FokSuzwpks5vBy_cgaJpZM4Z1pI5> .