stopped redundant processing and fixed close button. #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@harshkhandeparkar and @jywarren could you please review it. |
|
This looks really nice, thank you! Would you be able to add a GIF of this working and to refine the PR title a little so it's completely clear what the PR is for (as it shows up in our search results for clarity)? Thank you!!! |
|
This is the working Gif -
Is it ok now |
…ing of close button
|
Nice work!!!!! |
|
Thank u sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1411.
after this fix the close button works fine , and also when camera access is not provided no redundant processing is there
which solved both the mentioned problem.