-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for checking image change upon change in options #1490
Conversation
@keshav234156 @jywarren @harshkhandeparkar What are your thoughts on this? |
Codecov Report
@@ Coverage Diff @@
## main #1490 +/- ##
=======================================
Coverage 66.98% 66.98%
=======================================
Files 128 128
Lines 2626 2626
Branches 424 424
=======================================
Hits 1759 1759
Misses 867 867
|
@publiclab/is-reviewers |
test/core/templates/options-test.js
Outdated
|
||
/** | ||
* @method optionsChangeTest | ||
* @description a common test for modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please capitalize the first letter and add a full stop at the end of a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@harshkhandeparkar Do you think this is the best way to test this? Or should I look for an alternative? |
I guess it is good for now. I don't see any downside to this as of now. (But if we change the modules in the future, it may be a problem) |
If we change the modules in future the test will fail and corresponding benchark/options can be changed easily, i don't think that would be a problem. |
Great. Please make the requested changes. |
…e/image-sequencer into options-change-test
Wow, this is really super. Great work, @blurry-x-face !!! Thanks a ton! |
Fixes #1447
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowTests for the following modules have been added in this PR.