Fixes some of the test #1330
Fixes some of the test #1330
Conversation
updating
…ecting other modules
Codecov Report
@@ Coverage Diff @@
## main #1330 +/- ##
===========================================
+ Coverage 32.13% 66.58% +34.44%
===========================================
Files 108 125 +17
Lines 1982 2547 +565
Branches 292 397 +105
===========================================
+ Hits 637 1696 +1059
+ Misses 1345 851 -494
|
|
Oh! I just saw the coverage report. Coverage would almost be doubled and at all time maxima. @jywarren We are on the right path but need to work a harder on commented test module that was preventing other modules |
| // test('Text Overlay module works correctly', function(t) { |
There was a problem hiding this comment.
Can we use multi line comments here? /* */ Just a suggestion
|
@jywarren I think we should merge this so that our other test are not affected.what your view on this!!! |
|
Yes, ok let's merge this as soon as it passes! |
|
Can you make the PR title a little more descriptive? It's good to leave a more thorough history! Thanks a lot!!! |
|
@jywarren our next step should be fix 7 modules that i have mentioned in #1285 .For that i found the module were changed as it has some bugs like the rotate module was earlier having fixed dimension but corrosponding benchmarks were not changed as a result they are failing.So for this we can change the benchmarks of that modules.Then our next step should be if there is any failure in test then travis should raise an error rather than passing it .What your view 's regarding this? |
|
@jywarren Would take care of descriptive title from now on.Thanks!!! |
|
Thank you, that's a fantastic plan. And please copy your comment back into #1285 so we can continue tracking progress in one place -- thanks a ton!!! |
…ecting other modules (#1330)
Fixes Some of the #1285