-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display width and height of image at each step #1309
Conversation
@publiclab/is-reviewers @Divy123 please review this |
Codecov Report
@@ Coverage Diff @@
## main #1309 +/- ##
==========================================
- Coverage 32.26% 32.13% -0.13%
==========================================
Files 107 108 +1
Lines 1971 1982 +11
Branches 292 292
==========================================
+ Hits 636 637 +1
- Misses 1335 1345 +10
|
Can you please share a working GIF? Thanks!! |
Also please test the function added. You can add a unit test fir this. |
Thanks! Yes this is looking really good!
…On Thu, Nov 28, 2019, 10:48 AM Slytherin ***@***.***> wrote:
Alsi please test the function added. You can add a unit test fir this.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#1309?email_source=notifications&email_token=AAAF6J27OLQW2RZ6YA6HL43QV7R3BA5CNFSM4JSS6ZCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFM6UQY#issuecomment-559540803>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J2KPA3KYS472WNGEALQV7R3BANCNFSM4JSS6ZCA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks a lot for your contributions.
Good Luck!!
Awesome! Thanks!!!! |
Fixes #1023
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!