Add package-lock.json to .gitignore

[aashna27]

Adding package-lock.json to .gitignore would prevent it's unnecessary commit .

---

Thank you!

[gitmate]

GitMate.io thinks the contributors most likely able to help are @ccpandhare, and @jywarren.

Possibly related issues are #409 (Fix installation setup by improving package.json.), #570 (Add Valid HTML Types To Module info.json Files), #277 (add sequencer.importString()), #369 (Add a Grayscale module), and #158 (Add a Saturation Module).

[gitmate]

GitMate.io thinks the contributors most likely able to help are @ccpandhare, and @jywarren.

Possibly related issues are #409 (Fix installation setup by improving package.json.), #570 (Add Valid HTML Types To Module info.json Files), #277 (add sequencer.importString()), #369 (Add a Grayscale module), and #158 (Add a Saturation Module).

[vibhorgupta-gh]

I think we should actually commit the lock file since they lock the version being used by the project, for any new contributor to setup and not end up installing incompatible dependencies. Thoughts? @jywarren

[aashna27]

The dependency version is locked in package.json, and package-lock.json comes everytime npm install is done . And in case of conflicts in versions in package.json and package-lock.json the version of package.json is considered so I think ignoring package-lock while commiting is okay!! 😄

[vibhorgupta-gh]

@aashna27 https://stackoverflow.com/a/44210813 😅
The dependency version is actually locked in package-lock and not package.json. Also, the precedence being given to package.json in case of conflicts in versions is exactly why lock exists, to prevent such a thing from happening :D

Rest, admins may decide what seems fit

[harshkhandeparkar]

When a dependency is installed with npm i stall a lockfile is created and it is specifically stated that the lockfile should be commited. Lets just wait for the reviews' decision though. There may be another way around this.

[jywarren]

We could git-ignore the lock file but on the "build process" we're developing it could be force updated using `git add -f`, would that work?

…

On Mon, Jan 7, 2019 at 3:01 AM HarshKhandeparkar ***@***.***> wrote: When a project is initialized with npm init it is specifically stated that the lockfile should be commited. But there may be another way around this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#625 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3FIat6eDp4AIGpo0d9Cn_hKFRYtks5vAv7CgaJpZM4Zylxt> .

[aashna27]

We could add it to gitignore and also prevent its creation all together, Thoughts?

…

On Mon, Jan 7, 2019, 9:08 PM Jeffrey Warren ***@***.*** wrote: We could git-ignore the lock file but on the "build process" we're developing it could be force updated using `git add -f`, would that work? On Mon, Jan 7, 2019 at 3:01 AM HarshKhandeparkar ***@***.*** > wrote: > When a project is initialized with npm init it is specifically stated > that the lockfile should be commited. But there may be another way around > this? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #625 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AABfJ3FIat6eDp4AIGpo0d9Cn_hKFRYtks5vAv7CgaJpZM4Zylxt > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#625 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZUPyEQjgjV_1VAai1Pn3rCWqJ3oLa_4ks5vA2nggaJpZM4Zylxt> .

[tech4GT]

Oh we should leave the lock files in for sure.