forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step.toString() and sequencer.toString() methods #250
Milestone
Comments
This was referenced May 7, 2018
Here's where we're adding new steps to the URL hash string, which is similar although this code is not that flexible. With the new image-sequencer/examples/lib/defaultHtmlSequencerUi.js Lines 42 to 45 in 1de72d7
|
@jywarren I completely get this!! Awesome!! |
Yes, let's shift to this for the time being. Thanks! Thisll let us do the
string configuration in the URL and such. Very useful!
…On Mon, May 28, 2018, 6:47 PM Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> should I move onto this or
complete all the functions of #242
<#242> ??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#250 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ2yZQd8NPS74PHZiSjme6KCXgRa5ks5t3H5PgaJpZM4T1PKR>
.
|
This was referenced May 29, 2018
Merged
This was referenced Jun 3, 2018
This was referenced Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Breaking this out of #200 --
Based loosely on:
image-sequencer/examples/lib/defaultHtmlSequencerUi.js
Lines 30 to 37 in cbbfbff
and discussion from #200
Much discussion of how to implement per-step options in #127
however this can start with just a standardized way to get a list of all current steps in a string, so:
sequencer.toString()
Right now, each image in the sequencer has its own steps, but are these all identical? I feel they ought to be -- according to our model, it should be a consistent sequence that you then pass images through, not a collection of images which you assign steps to.
So really we may need to rework this to be
sequencer.steps
rather thansequencer._image_name_.steps
before we can continue this project.But once this is done, we can do a follow-up where each step can return its settings, like for example:
sequencer.step[0].toString() => "blur[amount:40]"
or similarThe text was updated successfully, but these errors were encountered: