-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make welcome page text to source from config.json file #216
Conversation
@jywarren @publiclab/reviewers I've opened this WIP pull request against issue #22. This work will make it easy for any org/user to use our project, all they need to do is to edit the Currently working on it, would love to have some feedback 😃 |
@jywarren @publiclab/reviewers My work regarding this PR is almost done. Now the main landing page ( Here's a GIF of my changes highlighting the places where data is fed from
( That yellow color is just for highlighting the places on the page, it is not included in the changes...and all the data is disabled in the GIF just to keep it short, no worries on that part also. ) |
This is so great!!!!! Is it ready for a review, or still in progress?
…On Wed, Jun 5, 2019, 1:40 AM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> @publiclab/reviewers
<https://github.com/orgs/publiclab/teams/reviewers> My work regarding
this PR is almost done. Now the main landing page (index.html) is
flexible to any org/user, they just need to update the config.json file
in the project root.
Here's a GIF of my changes highlighting the places where data is fed from
config.json file,
[image: portable]
<https://user-images.githubusercontent.com/25483260/58932486-931a0e00-8781-11e9-81f5-23ff758db62f.gif>
- I've added a dev-package named http-server to test/use the
config.json mechanism locally during development because JSON cannot
be fetched using the file protocol...Is it okay to leave it as is?
( That yellow color is just for highlighting the places on the page, it is
not included in the changes...and all the data is disabled in the GIF just
to keep it short, no worries on that part also. )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#216?email_source=notifications&email_token=AAAF6J5BSYWTWHM5CYP7VVLPY5GSLA5CNFSM4HSJIWS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6U6BQ#issuecomment-498945798>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J3LWHYMK6GT5MYZYJDPY5GSLANCNFSM4HSJIWSQ>
.
|
Yes, it's ready for review now... |
Looks great! Want to merge it? |
Yeah, sure! Thanks 😃 |
* Make welcome page text to source from config.json file. * add config for candidates
Fixes #22
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!