Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make welcome page text to source from config.json file #216

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

Rishabh570
Copy link
Collaborator

Fixes #22
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Rishabh570
Copy link
Collaborator Author

@jywarren @publiclab/reviewers I've opened this WIP pull request against issue #22.

This work will make it easy for any org/user to use our project, all they need to do is to edit the config.json file in the project root and the welcome page will get customized according to the info provided by them.

Currently working on it, would love to have some feedback 😃

@Rishabh570
Copy link
Collaborator Author

@jywarren @publiclab/reviewers My work regarding this PR is almost done. Now the main landing page (index.html) is flexible to any org/user, they just need to update the config.json file in the project root.

Here's a GIF of my changes highlighting the places where data is fed from config.json file,

portable

  • I've added a dev-package named http-server to test/use the config.json mechanism locally during development because JSON cannot be fetched using the file protocol...Is it okay to leave it as is?

( That yellow color is just for highlighting the places on the page, it is not included in the changes...and all the data is disabled in the GIF just to keep it short, no worries on that part also. )

@jywarren
Copy link
Member

jywarren commented Jun 6, 2019 via email

@Rishabh570
Copy link
Collaborator Author

Yes, it's ready for review now...

@Rishabh570 Rishabh570 changed the title [ WIP ] Make welcome page text to source from config.json file Make welcome page text to source from config.json file Jun 6, 2019
@jywarren
Copy link
Member

jywarren commented Jun 6, 2019

Looks great! Want to merge it?

@Rishabh570
Copy link
Collaborator Author

Yeah, sure! Thanks 😃

@Rishabh570 Rishabh570 merged commit bf490b3 into publiclab:main Jun 6, 2019
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
* Make welcome page text to source from config.json file.

* add config for candidates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable default welcome page text to source from .json file via URL hash
2 participants