Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#80 created the scroll to top button #140

Merged
merged 1 commit into from
Feb 15, 2019
Merged

#80 created the scroll to top button #140

merged 1 commit into from
Feb 15, 2019

Conversation

harshithpabbati
Copy link
Contributor

@harshithpabbati harshithpabbati commented Feb 14, 2019

Fixes: #80
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Feb 14, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@harshithpabbati
Copy link
Contributor Author

@publiclab/is-reviewers

@harshithpabbati
Copy link
Contributor Author

@publiclab/reviewers

@harshithpabbati
Copy link
Contributor Author

@jywarren can you please review it

@jywarren
Copy link
Member

Hi, thank you! can you post a screenshot?

@harshithpabbati
Copy link
Contributor Author

screenshot from 2019-02-15 12-40-17

@harshithpabbati
Copy link
Contributor Author

scroll to top button on the right-bottom of the screen

@harshithpabbati
Copy link
Contributor Author

@publiclab/is-reviewers

@jywarren jywarren merged commit 73d1528 into publiclab:main Feb 15, 2019
@welcome
Copy link

welcome bot commented Feb 15, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Great work! @Rishabh570 have a look!

@harshithpabbati
Copy link
Contributor Author

@Harshith1304 is my twitter handle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Scroll To Top Button
2 participants