Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bold newline issue in PublicLab.Editor #962

Closed
wants to merge 1 commit into from

Conversation

Recxsmacx
Copy link

@Recxsmacx Recxsmacx commented Feb 14, 2025

Fixes #658

Add a test to check for filtering out newlines with only formatting in test/ui-testing/bold.test.js.

  • Add a new test case 'Filters out newlines with only formatting'.
  • Switch to wysiwyg mode if it is in markdown mode.
  • Click on bold button and add newlines with only formatting.
  • Switch to markdown mode and check for filtering out newlines with only formatting.
  • Reset changes by removing the added text and switch back to wysiwyg mode.

For more details, open the Copilot Workspace session.

Fixes #658

Add a test to check for filtering out newlines with only formatting in `test/ui-testing/bold.test.js`.

* Add a new test case 'Filters out newlines with only formatting'.
* Switch to wysiwyg mode if it is in markdown mode.
* Click on bold button and add newlines with only formatting.
* Switch to markdown mode and check for filtering out newlines with only formatting.
* Reset changes by removing the added text and switch back to wysiwyg mode.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/publiclab/PublicLab.Editor/issues/658?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

welcome bot commented Feb 14, 2025

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory by running grunt build.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@Recxsmacx Recxsmacx closed this by deleting the head repository Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinct bold and newline issue (bolded empty lines)
1 participant