Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make history icons consistent #572

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Conversation

DiegoValenciaRoman
Copy link
Contributor

fixes #570

@welcome
Copy link

welcome bot commented Jul 23, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Jul 23, 2020

@Shulammite-Aso
Copy link
Collaborator

Shulammite-Aso commented Jul 23, 2020

Thanks @DiegoValenciaRoman, we'll just wait for all checks to complete.

Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯 🎉

@Shulammite-Aso
Copy link
Collaborator

@sagarpreet-chadha any idea why one travis check is still in progress here?

@gitpod-io
Copy link

gitpod-io bot commented Jul 25, 2020

@sagarpreet-chadha
Copy link
Contributor

Sometimes tests fail due to tests that are dependent on timing maybe or gets stalled due to server load. Triggering it again works most of the times :)

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jul 29, 2020

Thanks everyone for the reviews 🎉 thanks @DiegoValenciaRoman for working on this and welcome to PublicLab 🎈

@cesswairimu cesswairimu merged commit 262aeb2 into publiclab:main Jul 29, 2020
@welcome
Copy link

welcome bot commented Jul 29, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly?
Do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make history icons consistent
4 participants