-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added _calculateAngle to L.EditHandle #267
Conversation
Thanks for opening this pull request! |
@sashadev-sky please review this pull request once and let me know if i need to change something. Thanks:) |
@AdityaShD This is really great work, thank you!! 😊 I'm going to rebase it for you because I just merged another PR updating these files. Then I will merge it! |
e65a5a3
to
1df1463
Compare
Congrats on merging your first pull request! 🙌🎉⚡️ |
Oh @AdityaShD one quick tip for future PRs - I just realized this myself: don't put parentheses around the issue # when you write fixes #260 . The exact syntax given in the template (without the parentheses) triggers the connected issue to automatically close when its corresponding PR is merged. |
sure, i'll keep it mind next time 😊 |
My twitter handle is @aditya_sh |
Fixes (#260 )
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!