Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added _calculateAngle to L.EditHandle #267

Merged
merged 1 commit into from
May 20, 2019

Conversation

AdityaShD
Copy link
Contributor

@AdityaShD AdityaShD commented May 20, 2019

Fixes (#260 )

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented May 20, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@AdityaShD
Copy link
Contributor Author

@sashadev-sky please review this pull request once and let me know if i need to change something. Thanks:)

@sashadev-sky
Copy link
Member

@AdityaShD This is really great work, thank you!! 😊 I'm going to rebase it for you because I just merged another PR updating these files.

Then I will merge it!

@sashadev-sky sashadev-sky merged commit 4652cb9 into publiclab:main May 20, 2019
@welcome
Copy link

welcome bot commented May 20, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@sashadev-sky
Copy link
Member

sashadev-sky commented May 20, 2019

Oh @AdityaShD one quick tip for future PRs - I just realized this myself:

don't put parentheses around the issue # when you write fixes #260 . The exact syntax given in the template (without the parentheses) triggers the connected issue to automatically close when its corresponding PR is merged.

@AdityaShD
Copy link
Contributor Author

Oh @AdityaShD one quick tip for future PRs - I just realized this myself:

don't put parentheses around the issue # when you write fixes #260 . The exact syntax given in the template (without the parentheses) triggers the connected issue to automatically close when its corresponding PR is merged.

sure, i'll keep it mind next time 😊

@AdityaShD
Copy link
Contributor Author

Congrats on merging your first pull request!
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

My twitter handle is @aditya_sh
Thanks 😄

@AdityaShD
Copy link
Contributor Author

AdityaShD commented Apr 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants