New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

referenced the issue#1298 #1299

Closed

Nehemiah60 wants to merge 1 commit into publiclab:main from Nehemiah60:referencing

Nehemiah60 commented Dec 15, 2022

Fixes #1298

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updates
@mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!


          referenced the issue#1298

b7e25fb

Collaborator

7malikk commented Dec 15, 2022

Hello @Nehemiah60, the changes you made here, should've been done on #1298

I'll be closing this PR so we can work through effecting those changes on #1298
Thank you!

7malikk closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet