Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add GitHub workflows and make the Repo green #6

Merged
merged 8 commits into from
Mar 14, 2024
Merged

chore: add GitHub workflows and make the Repo green #6

merged 8 commits into from
Mar 14, 2024

Conversation

deleonio
Copy link

@deleonio deleonio commented Mar 11, 2024 •
edited
Loading

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Code review performed successfully

@deleonio deleonio force-pushed the chore/add-workflows branch 3 times, most recently from 2609475 to d501de4 Compare March 11, 2024 14:03
@deleonio deleonio requested a review from sdvg March 11, 2024 14:04
@deleonio deleonio changed the title chore: add ci pipe chore: add github workflows Mar 11, 2024
sdvg
sdvg requested changes Mar 11, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
@deleonio deleonio force-pushed the chore/add-workflows branch 2 times, most recently from c1f6726 to 148027c Compare March 12, 2024 16:29
@deleonio deleonio requested a review from sdvg March 12, 2024 16:30
@deleonio deleonio force-pushed the chore/add-workflows branch 3 times, most recently from 9aa42fa to 8546dc0 Compare March 13, 2024 09:23
@deleonio
Copy link
Author

deleonio commented Mar 13, 2024 •
edited
Loading

Hi @sdvg,

ich habe jetzt ein paar Verbesserungen vorgenommen, sodass das Repo genauso funktioniert, wie ursprünglich.

Jetzt schlagen am Ende nur noch die Tests vom Angular-Adapter (packages/example-project/component-library-angular) fehl. Kannst Du Dir das bitte mal anschauen?

Ich verwende zum Arbeiten folgende Befehle: npm i && npm run bootstrap && npm run build && npm test

Hinweis: Wenn einmal alles gebaut ist, dann kannst Du auch einfach in den einzelnen Packages die Befehle ausführen, die Du brauchst.

Danke

@deleonio deleonio force-pushed the chore/add-workflows branch from 8546dc0 to 0bacc26 Compare March 14, 2024 05:24
@deleonio deleonio changed the title chore: add github workflows chore: add GitHub workflows and make the Repo green Mar 14, 2024
deleonio
deleonio commented Mar 14, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/react-output-target/package.json Outdated Show resolved Hide resolved
@sdvg sdvg force-pushed the chore/add-workflows branch from b79ca3f to 0bacc26 Compare March 14, 2024 10:55
@deleonio deleonio merged commit 0487a0d into main Mar 14, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deleonio @sdvg