Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove auto scrollToErrorList call #7357

Closed
wants to merge 1 commit into from

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Feb 4, 2025

This pull request includes several changes to the packages/components module, focusing on improving code readability and type safety. The most important changes include the removal of a method call in the KolForm class and a modification to an import statement in the error-list schema.

Code readability improvements:

Type safety improvements:

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio force-pushed the fix/form-error-list-focus branch from d5f1945 to 4c6dc85 Compare February 4, 2025 20:44
Copy link
Contributor

github-actions bot commented Feb 4, 2025

@deleonio deleonio changed the title refactor: remove unnecessary scrollToErrorList call and update import… refactor: remove auto scrollToErrorList call Feb 5, 2025
@deleonio deleonio changed the title refactor: remove auto scrollToErrorList call refactor: remove auto scrollToErrorList call Feb 5, 2025
@deleonio deleonio linked an issue Feb 5, 2025 that may be closed by this pull request
@deleonio deleonio closed this Feb 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Callback bei ErrorList
1 participant