Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate _minWidth property in table components and update related d… #7344

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Deprecate _minWidth property in table components and update related d… #7344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/components/src/components/table-stateful/shadow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export class KolTableStateful implements TableAPI {

/**
* Defines the table min-width.
* @deprecated This property is deprecated and will be removed in the next major release.
*/
@Prop() public _minWidth?: string;

Expand Down Expand Up @@ -327,6 +328,9 @@ export class KolTableStateful implements TableAPI {
});
}

/**
* @deprecated This property is deprecated and will be removed in the next major release.
*/
@Watch('_minWidth')
public validateMinWidth(value?: string): void {
watchString(this, '_minWidth', value, {
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/table-stateless/shadow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export class KolTableStateless implements TableStatelessProps {

/**
* Defines the table min-width.
* @deprecated This property is deprecated and will be removed in the next major release.
*/
@Prop() public _minWidth?: string;

Expand Down
1 change: 1 addition & 0 deletions packages/components/src/components/table/shadow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export class KolTable implements TableProps {

/**
* Defines the table min-width.
* @deprecated This property is deprecated and will be removed in the next major release.
*/
@Prop() public _minWidth?: string;

Expand Down
6 changes: 6 additions & 0 deletions packages/components/src/schema/components/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ type RequiredProps = {
PropLabel;
type OptionalProps = {
allowMultiSort: boolean;
/**
* @deprecated This property is deprecated and will be removed in the next major release.
*/
minWidth: string;
pagination: boolean | Stringified<KoliBriTablePaginationProps>;
} & PropTableDataFoot &
Expand All @@ -63,6 +66,9 @@ type RequiredStates = {
} & PropLabel &
PropPaginationPosition;
type OptionalStates = {
/**
* Needed for internal use.
*/
minWidth: string;
sortDirection: KoliBriSortDirection;
selection: KoliBriTableSelection;
Expand Down
Loading