Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove modal property in Drawer #7247

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Remove modal property in Drawer #7247

merged 6 commits into from
Jan 20, 2025

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Jan 16, 2025 •
edited
Loading

Refs: #6899

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne linked an issue Jan 16, 2025 that may be closed by this pull request
9.2.1.1 - Drawer: Ohne Maus nutzbar #6899
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://678e4d391c27893f9dfddb8e--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/678e4d391c27893f9dfddb8e

sdvg
sdvg requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Änderungen sehen soweit gut aus!

Wir sollten noch die Sample App anpassen:

  • Erwähnung von Modal in der Sample-Beschreibung muss raus.
  • Unterscheidung mit den zwei Buttons (Open drawer, Open drawer as modal) ergibt so keinen Sinn mehr.

@anicyne anicyne force-pushed the 6899-fix-drawer-navigation-v3 branch from 1238744 to 05e1e6a Compare January 20, 2025 09:26
@anicyne anicyne requested a review from sdvg January 20, 2025 09:45
sdvg
sdvg requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das Drawer controller Beispiel hat immer noch einen Modal Button.

@anicyne anicyne force-pushed the 6899-fix-drawer-navigation-v3 branch from 406d3e7 to cd2d52a Compare January 20, 2025 11:48
@anicyne anicyne force-pushed the 6899-fix-drawer-navigation-v3 branch from d905e14 to 2a03daa Compare January 20, 2025 12:16
@anicyne anicyne requested a review from sdvg January 20, 2025 12:30
@anicyne anicyne force-pushed the 6899-fix-drawer-navigation-v3 branch from 8760eda to 81a57a3 Compare January 20, 2025 13:03
@sdvg sdvg merged commit 01bb5c0 into develop Jan 20, 2025
9 checks passed
@sdvg sdvg deleted the 6899-fix-drawer-navigation-v3 branch January 20, 2025 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdvg sdvg sdvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9.2.1.1 - Drawer: Ohne Maus nutzbar
2 participants
@anicyne @sdvg