Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance visual tests by adding snapshot tests for different viewport … #7172

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Dec 10, 2024

…sizes and zoom levels

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio added the v2 label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

@sdvg sdvg linked an issue Dec 10, 2024 that may be closed by this pull request
@deleonio deleonio requested a review from sdvg December 10, 2024 16:20
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deleonio Ich hatte das PR heute morgen schon mal angeschaut: Funktioniert das Feature sicher schon wie gewünscht?

Bei den neuen Snapshots kann ich keinen Zoom erkennen.
Bei den bestehenden Snapshots fände ich es eigentlich schön, wenn die Viewport-Size gleich (=klein) bliebe. Bei den sehr großen VP mit viel Weißraum wird es schwieriger, Abweichungen zu sehen.

@deleonio
Copy link
Contributor Author

@deleonio Ich hatte das PR heute morgen schon mal angeschaut: Funktioniert das Feature sicher schon wie gewünscht?

Bei den neuen Snapshots kann ich keinen Zoom erkennen. Bei den bestehenden Snapshots fände ich es eigentlich schön, wenn die Viewport-Size gleich (=klein) bliebe. Bei den sehr großen VP mit viel Weißraum wird es schwieriger, Abweichungen zu sehen.

Danke, ich habe es jetzt glaube besser hinbekommen 😄 .

@deleonio deleonio requested a review from sdvg December 10, 2024 21:30
@deleonio deleonio linked an issue Dec 10, 2024 that may be closed by this pull request
@sdvg sdvg merged commit 3d6f13a into release/2 Dec 11, 2024
7 checks passed
@sdvg sdvg deleted the feature/7171-v2 branch December 11, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshot Tests um 400% erweitern Virtual-Tests-Modul stößt mit Node.js v22 auf einen Fehler
3 participants