Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply BEM refactoring to quote and pagination #7117

Merged
merged 16 commits into from
Nov 29, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Nov 25, 2024

Refs: #7036

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@anicyne anicyne marked this pull request as draft November 25, 2024 15:33
@anicyne anicyne linked an issue Nov 25, 2024 that may be closed by this pull request
55 tasks
@anicyne anicyne mentioned this pull request Nov 25, 2024
55 tasks
Copy link
Contributor

github-actions bot commented Nov 25, 2024

@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Nov 26, 2024
@anicyne anicyne force-pushed the 7036-bem-refactoring-quote-und-pagination branch 2 times, most recently from ba65699 to c904e36 Compare November 27, 2024 06:43
@anicyne anicyne force-pushed the 7036-bem-refactoring-quote-und-pagination branch from c3eddc9 to 921aa99 Compare November 27, 2024 07:05
@anicyne anicyne marked this pull request as ready for review November 27, 2024 08:29
@anicyne anicyne marked this pull request as draft November 27, 2024 11:16
@anicyne anicyne marked this pull request as ready for review November 28, 2024 07:01
@anicyne anicyne marked this pull request as draft November 28, 2024 07:01
@anicyne anicyne force-pushed the 7036-bem-refactoring-quote-und-pagination branch from 665682e to 81e0a30 Compare November 28, 2024 10:16
@anicyne anicyne requested a review from sdvg November 28, 2024 10:30
@anicyne anicyne marked this pull request as ready for review November 28, 2024 10:31
@anicyne anicyne requested a review from sdvg November 28, 2024 19:21
@anicyne anicyne force-pushed the 7036-bem-refactoring-quote-und-pagination branch from 4b97927 to f9a2ab5 Compare November 29, 2024 08:32
Copy link
Member

@sdvg sdvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bis auf die Änderungen in den Snapshots (anscheinend font-family) sieht alles gut aus.

@anicyne anicyne force-pushed the 7036-bem-refactoring-quote-und-pagination branch from 4797321 to f47b1ae Compare November 29, 2024 14:23
@sdvg sdvg merged commit a328c84 into develop Nov 29, 2024
11 of 12 checks passed
@sdvg sdvg deleted the 7036-bem-refactoring-quote-und-pagination branch November 29, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BEM-Refactoring
3 participants